Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1107588ybt; Tue, 7 Jul 2020 07:59:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPflulczoYxWOIrLVX4oPkKHHXJ1WuNnUI4WcMW2t6Zt5jmb/ljnvDFWcl/P1w0KjCaksv X-Received: by 2002:a17:906:b888:: with SMTP id hb8mr47359424ejb.124.1594133951134; Tue, 07 Jul 2020 07:59:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594133951; cv=none; d=google.com; s=arc-20160816; b=sen6rIpKxnBzQkECPg/H425C7ut8VZsnFQqodxFI4/aLdocQmskF7wrPGAMwu6pvDC 9TMVeLRGyMNy+DO8dQjSXfeyrrGzzIYYQMS0QOPjUZDBfuSjdnbAgQqrf3uTFG/zx03q ecXw9BX2Un8YTXMoCQ6OmFoVW0Kai14g4/7B16Qwxr23qxYylWvNNQcdBOTIa7J/YJlq b+WsOnCaMo8SQHRuSKRan7zRbjWuPi5BSiGAZ9yBMJg3PF9O41CJXEGnym+injFZLOvc 16XnGUCkGzmZTK0j41q3ZT+q8gkVXWM2gmFymR5DTrWs+dXb/o3H83BPK9gkQA8JEF3W jjow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=HA5WMwxscQ78XPUobFav00uOAsyHepNEfosz5Ea/uJ8=; b=UMZqm76iEdv9FM+OKZhoRC0+q4sC0UQvvTjsZE26pN/E+eBVOe1dHQnA3ep7ZbslIN TqHFVoiYdVNzaSFGhGx5tTa/E1DTQhKrEE6kXpKGQR4FP3Tt1+rkOawkWpTh2T9OL9lO oa+BplRXn6hKj3NFJ4NwZAjskSNacCMurnqIPojx0fyxtcqK8RWITNOo2u7vQ9ATNr6t HJH5v/PeZUUu2aHWu7z71DPQ7eUdEOdzaWrNZujgD28QRWnYezUublXqM9gbEV3FT0oq VOROmoye/3NRWTn6I7F64EAjmIFSmojUArXYGO3WFpvqSsrsrGkREyrlccv/CibcRFlf 4mcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gdOF9UeY; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si15700612ejm.223.2020.07.07.07.58.39; Tue, 07 Jul 2020 07:59:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gdOF9UeY; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbgGGO6I (ORCPT + 99 others); Tue, 7 Jul 2020 10:58:08 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:54478 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727936AbgGGO6I (ORCPT ); Tue, 7 Jul 2020 10:58:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594133887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HA5WMwxscQ78XPUobFav00uOAsyHepNEfosz5Ea/uJ8=; b=gdOF9UeYW3VLdJ6pm8PBbmNdJ7AemlOL966nRbuT9Rc+zKEGpyop4CD8u2D9OJCADYDVIT O+S1PRh+7azzD+Z6FWeMGfF50+Nvij/fMuKxqMkDyoHQ/78hqWXZSTnPWjh9bI6WhO6yU/ kPJAIP9dePNV9tVKv1f+6zByo+otjCM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-gKEQs8PXN_q4VqK0W0v_Dw-1; Tue, 07 Jul 2020 10:58:05 -0400 X-MC-Unique: gKEQs8PXN_q4VqK0W0v_Dw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84B0A108BD0D; Tue, 7 Jul 2020 14:58:04 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AD335C1B2; Tue, 7 Jul 2020 14:58:01 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 067Ew1T3013602; Tue, 7 Jul 2020 10:58:01 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 067Ew1xA013598; Tue, 7 Jul 2020 10:58:01 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Tue, 7 Jul 2020 10:58:00 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Eric Biggers cc: linux-crypto@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 0/6] crypto: add CRYPTO_ALG_ALLOCATES_MEMORY In-Reply-To: <20200706185403.GA736284@gmail.com> Message-ID: References: <20200701045217.121126-1-ebiggers@kernel.org> <20200706185403.GA736284@gmail.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, 6 Jul 2020, Eric Biggers wrote: > On Wed, Jul 01, 2020 at 03:59:10AM -0400, Mikulas Patocka wrote: > > Thanks for cleaning this up. > > > > Mikulas > > Do you have any real comments on this? > > Are the usage restrictions okay for dm-crypt? > > - Eric I think that your patch series is OK. dm-crypt submits crypto requests with size aligned on 512 bytes. The start of the crypto request is usually aligned on 512 bytes, but not always - XFS with SLUB_DEBUG will send bios with misaligned bv_offset (but the bio vectors don't cross a page). Mikulas