Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1364114ybt; Thu, 9 Jul 2020 05:20:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMlE2lS7SG9O3TkJUdq/r/CCupDnlC9bMcU0eqSCwDkdNRM74kTTz30ZJwrNH8gDxJJiCJ X-Received: by 2002:a17:906:774d:: with SMTP id o13mr50675142ejn.373.1594297248430; Thu, 09 Jul 2020 05:20:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594297248; cv=none; d=google.com; s=arc-20160816; b=xyjSsEVvlbVGKTW0/qZGE33kvBcLfED7UvrQi22x949DX6CknOreYGEkLc5otBeJ+A r0iZXMN+JL1ccY0qtaIU3wjbjE3F/07ujFOIFguN4h6AoIZlke34pu7QjKLQe94SxkXB qmv7OP36ADgXplEGNp4c9LF1R2EJFfBKivhEADd1LMxWRaA9DJ5rn6EWl1+6P1exs4/O 0K0ipqaf6TVrgH4XnzgMV4EN85t2bmLhgc3oO38LmQYN5zzXOhB/t1AqygliYhMi6o6Z 3IpO4RQakTwHe0MI9kDNe8oXpbzvmXLTPZO2ZCkZVBpUktd568JaBv9VCM6FcFHCgFtC cdrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0qKPYbwtvqJQ6SL/j98DZdlDWS9tZQWkjYNNOc0cn/Y=; b=ZGr4h4ELDqzJLrC2hrWGIrPx5R2alsJm4Ms7pxpq6u3SA8RJaeS4ziwnBeyxxrqd6L STM0BC3m5MGmaC2Way7FUTChCUHqk+4a9Y568uPl4VZQYF07+1teIb9De0P2eDiKopbZ wmDXMiU8PDehQy62sKXXQruLnxf/Va33jFFka8xiq1XKM+oAz18wwUu3Zoqu0qdCgZrS X/GvfXGaRh8wnPa0TyXOSYTzTlc6bzaZi/k1R7bi0PpJfAu62DnRXTO/D0GgInBhBSsH osF4WdBOOLSzNc0kaWZZ4ffWIUo7tICLHS9nYfmBPHe1g24gFEFfiyz0HFfr8ekxcqnV pkjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si1945119edm.24.2020.07.09.05.20.24; Thu, 09 Jul 2020 05:20:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbgGIMUV (ORCPT + 99 others); Thu, 9 Jul 2020 08:20:21 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:36016 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgGIMUV (ORCPT ); Thu, 9 Jul 2020 08:20:21 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jtVXE-0003JN-OL; Thu, 09 Jul 2020 22:20:17 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 09 Jul 2020 22:20:16 +1000 Date: Thu, 9 Jul 2020 22:20:16 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH 0/5] crypto: clean up ARM/arm64 glue code for GHASH and GCM Message-ID: <20200709122016.GA17502@gondor.apana.org.au> References: <20200629073925.127538-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629073925.127538-1-ardb@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 29, 2020 at 09:39:20AM +0200, Ard Biesheuvel wrote: > Get rid of pointless indirect calls where the target of the call is decided > at boot and never changes. Also, make the size of the key struct variable, > and only carry the extra keys needed for aggregation when using a version > of the algorithm that makes use of them. > > Ard Biesheuvel (5): > crypto: arm64/ghash - drop PMULL based shash > crypto: arm64/gcm - disentangle ghash and gcm setkey() routines > crypto: arm64/gcm - use variably sized key struct > crypto: arm64/gcm - use inline helper to suppress indirect calls > crypto: arm/ghash - use variably sized key struct > > arch/arm/crypto/ghash-ce-glue.c | 51 ++-- > arch/arm64/crypto/ghash-ce-glue.c | 257 +++++++------------- > 2 files changed, 118 insertions(+), 190 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt