Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1384758ybt; Thu, 9 Jul 2020 05:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT811Ai2OnR3/HS0FUFZNC1NaJBqMqPCflIWMsms+BPaGiwg2vx9i8RiiMdPzYzB40Pmzj X-Received: by 2002:aa7:c885:: with SMTP id p5mr58755822eds.100.1594299306931; Thu, 09 Jul 2020 05:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594299306; cv=none; d=google.com; s=arc-20160816; b=T6elfqRfXFvDFgVuOrTTkbKuQuLXlAMoiPFLpoW+nTWXdqpTg7LAflyBJCDLjo4R8W r3tZ6tkPqVc1FFlSZmbFOMl4uyCxVPkxQ0VWYV4T2TySch6Gjy4H7t+OHCcO+i7xb0qy WgNsxNTjqpT3VrrbpMyOxIDS8zivgMpxjS7VsQvHWKrUMuR+p2RmokMyjytUpsTjFpOi ShWH9F3hHxRq0Npq1bAApK+algPXkMsHAKQ18jKEBo2JgE+lbx+UGyGLFqzazuh3+WKz wcLJSkO9ufkkXWkFvDmvvvceRQ2LpLvICUuOkIZpnx1ZuYFqFEoag+NHhPdzSGyV62zi ikLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2zN9xT9eV6WexYKFfG5S4I2dsTBm8QILUze22+4GLxU=; b=irPI6tBXIeYqoO9UPtnMwlqBaIJ7mBF6gM1ek8xkFywmiw5ey+8LaLGbC4MEy61EII oHJTqCdhUw/Yk4+HRXz09i0nd55J3YeToyorAAVtBoMJLPHLEqukbaXvHglt3azbGsQl TTEOj7JAErdD4Ugihk/Go8FV6tbweVJVq5uAokSbpQm3u7lZbsQc1fv/rbq4zepvP38/ tf8KPFO71UXD1Y+s3cu0gMuBLuUrau/5O4yF37kfOoq/SrU6C8rnAsit5Uu5Sck/Czl7 +3JsoXChKBQlZ304GyL9uSL95iT/GMDBUC1vy6pkWkCu1DVs/LJTk/vERZJem1lsUugu VTtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si1916549edt.374.2020.07.09.05.54.44; Thu, 09 Jul 2020 05:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbgGIMx4 (ORCPT + 99 others); Thu, 9 Jul 2020 08:53:56 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:36120 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726347AbgGIMxz (ORCPT ); Thu, 9 Jul 2020 08:53:55 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jtW3i-0003v5-1F; Thu, 09 Jul 2020 22:53:51 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 09 Jul 2020 22:53:50 +1000 Date: Thu, 9 Jul 2020 22:53:50 +1000 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com Subject: Re: [PATCH v3 0/4] crypto: qat - fixes to aes xts Message-ID: <20200709125349.GB31057@gondor.apana.org.au> References: <20200629171620.2989-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629171620.2989-1-giovanni.cabiddu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 29, 2020 at 06:16:16PM +0100, Giovanni Cabiddu wrote: > This series fixes a few issues with the xts(aes) implementation in the > QuickAssist driver: > - Requests that are not multiple of the block size are rejected > - Input key not validated > - xts(aes) requests with key size 192 bits are rejected with -EINVAL > > Changes from v2: > - Patch #4 - removed CRYPTO_ALG_ASYNC flag from mask in the allocation > of the fallback tfm to allow asynchronous implementations as fallback. > - Patch #4 - added CRYPTO_ALG_NEED_FALLBACK flag as mask when allocating > fallback tfm to avoid implementations that require fallback. > - Reworked commit messages to have system logs in one line. > > Changes from v1: > - Removed extra pair of parenthesis around PTR_ERR in patch #4 (crypto: > qat - allow xts requests not multiple of block) > > Giovanni Cabiddu (4): > crypto: qat - allow xts requests not multiple of block > crypto: qat - validate xts key > crypto: qat - remove unused field in skcipher ctx > crypto: qat - fallback for xts with 192 bit keys > > drivers/crypto/qat/qat_common/qat_algs.c | 98 ++++++++++++++++++++++-- > 1 file changed, 90 insertions(+), 8 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt