Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCHv5 2/7] crypto: sa2ul: Add crypto driver
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <j-keerthy@ti.com>
References: <20200701080553.22604-1-t-kristo@ti.com>
 <20200701080553.22604-3-t-kristo@ti.com>
 <20200709080301.GA11760@gondor.apana.org.au>
 <20200709080612.GA16409@gondor.apana.org.au>
From:   Tero Kristo <t-kristo@ti.com>
Message-ID: <c3cc7fcf-c5c4-8329-f669-2f512a44ac44@ti.com>
Date:   Mon, 13 Jul 2020 11:40:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200709080612.GA16409@gondor.apana.org.au>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 09/07/2020 11:06, Herbert Xu wrote:
> On Thu, Jul 09, 2020 at 06:03:01PM +1000, Herbert Xu wrote:
>> On Wed, Jul 01, 2020 at 11:05:48AM +0300, Tero Kristo wrote:
>>> From: Keerthy <j-keerthy@ti.com>
>>>
>>> Adds a basic crypto driver and currently supports AES/3DES
>>> in cbc mode for both encryption and decryption.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> [t-kristo@ti.com: major re-work to fix various bugs in the driver and to
>>>   cleanup the code]
>>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>>> ---
>>>   drivers/crypto/Kconfig  |   14 +
>>>   drivers/crypto/Makefile |    1 +
>>>   drivers/crypto/sa2ul.c  | 1391 +++++++++++++++++++++++++++++++++++++++
>>>   drivers/crypto/sa2ul.h  |  380 +++++++++++
>>>   4 files changed, 1786 insertions(+)
>>>   create mode 100644 drivers/crypto/sa2ul.c
>>>   create mode 100644 drivers/crypto/sa2ul.h
>>
>> I get lots of sparse warnings with this driver.  Please fix them
>> and resubmit.
> 
> Please also compile test with W=1.

Just fixed all these and posted v6.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki