Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1017911ybh; Thu, 16 Jul 2020 00:22:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOWzzzPC84plrMY2GAfp52RBiGL1dcmQZfqVeNzXtLU3aAhtJ9G264YNkaVZ/V5gxp6WNa X-Received: by 2002:a05:6402:228d:: with SMTP id cw13mr3205897edb.343.1594884132478; Thu, 16 Jul 2020 00:22:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594884132; cv=none; d=google.com; s=arc-20160816; b=N+0p01v8b+wvap5qCRRy+NFK9tOXEnQ/Eh+uNuz8uigj4qjcRsQ8bq+b1YHA2Lj+hZ LUOf0r/9Sa9EtlSUOTs8SavpjrXDCWHO3YWalXILUEkOiyIh+SlkA9d7ZLe6Z1BUmHGm frd8Wh71UcaADWzeijWl7Jk/+Y0U5W/YDYWHHf9u49Ikxp78aZbKcRe48xE5hniUSbi8 PrT7GCXR38NYIm1tSXQxah69sLpClMblhsJlzFMdytlCH/WLULYEGNon74mkG6JCPu9Q naD1J4dNYpa0oUTVwFtz6O4yHgPxRf0AfWZS4hKxtBXouWxsxfjbrOREjExRt5gU9WpV bIQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=eQYLkHXnWkGIJo/yaix4gRbBn8/Xr/aIhV/cTaMIAgs=; b=EqLgFxyk32yc/LP2VzqVJCBlgfAr3ViTRgBcDyrFOnEB4nW2lTtI1ffOXNFcMP4Cm5 dkHzt2z7u8O6f56lcoJk5I4LJI3gAvEAhamhPQOqkvp1IZPmfgp3nou/j3AIItDCX38I s7BpHM1pKPmjW8mWRFGXCtQSBfni9rq03atzIndoT3ZxoKNefsIB2o2iubNFPBbHmnAN 7mo23Ajz+RSUxyiOcT20YvvEFGRZJl0rvBRaxShgY0sqD5fOyL271ProcelAp0J2tJZq Dyv3bHHGq7knJ9ugxm11IfWY69OW3uMeXzinu8nV7WfQSUuD++NrRXSC9zo+1muZkEan hLCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si2632790ejq.283.2020.07.16.00.21.40; Thu, 16 Jul 2020 00:22:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgGPHVi (ORCPT + 99 others); Thu, 16 Jul 2020 03:21:38 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:39588 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbgGPHVh (ORCPT ); Thu, 16 Jul 2020 03:21:37 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jvyCz-0003RY-BT; Thu, 16 Jul 2020 17:21:34 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 16 Jul 2020 17:21:33 +1000 Date: Thu, 16 Jul 2020 17:21:33 +1000 From: Herbert Xu To: Sven Auhagen Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH 1/1] inside-secure irq balance Message-ID: <20200716072133.GA28028@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708150844.2626m3pgdo5oidzm@SvensMacBookAir.sven.lan> X-Newsgroups: apana.lists.os.linux.cryptoapi User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Sven Auhagen wrote: > > + // Set affinity > + cpu = ring_id % num_online_cpus(); > + irq_set_affinity_hint(irq, get_cpu_mask(cpu)); > + This doesn't look right. There is no guarantee that the online CPUs are the lowest bits in the bitmask. Also, what are you going to do when the CPUs go down (or up)? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt