Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Jul 2020 21:53:34 +1000
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Corentin Labbe <clabbe@baylibre.com>,
        "David S. Miller" <davem@davemloft.net>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        John Allen <john.allen@amd.com>,
        Ayush Sawal <ayush.sawal@chelsio.com>,
        Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
        Rohit Maheshwari <rohitm@chelsio.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Jamie Iles <jamie@jamieiles.com>,
        Eric Biggers <ebiggers@google.com>,
        Tero Kristo <t-kristo@ti.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
        linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 00/13] crypto: permit asynchronous skciphers as driver
 fallbacks
Message-ID: <20200716115334.GB31166@gondor.apana.org.au>
References: <20200707063203.5018-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200707063203.5018-1-ardb@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 07, 2020 at 09:31:50AM +0300, Ard Biesheuvel wrote:
> The drivers for crypto accelerators in drivers/crypto all implement skciphers
> of an asynchronous nature, given that they are backed by hardware DMA that
> completes asynchronously wrt the execution flow.
> 
> However, in many cases, any fallbacks they allocate are limited to the
> synchronous variety, which rules out the use of SIMD implementations of
> AES in ECB, CBC and XTS modes, given that they are usually built on top
> of the asynchronous SIMD helper, which queues requests for asynchronous
> completion if they are issued from a context that does not permit the use
> of the SIMD register file.
> 
> This may result in sub-optimal AES implementations to be selected as
> fallbacks, or even less secure ones if the only synchronous alternative
> is table based, and therefore not time invariant.
> 
> So switch all these cases over to the asynchronous API, by moving the
> subrequest into the skcipher request context, and permitting it to
> complete asynchronously via the caller provided completion function.
> 
> Patch #1 is not related, but touches the same driver as #2 so it is
> included anyway. Patch #13 removes another sync skcipher allocation by
> switching to the AES library interface.
> 
> v4:
> - add missing kerneldoc updates for sun8i-ce and sun8i-ss
> - add acks from Horia, Jamie and Corentin
> - rebase onto cryptodev/master
> 
> v3:
> - disregard the fallback skcipher_request when taking the request context size
>   for TFMs that don't need the fallback at all (picoxcell, qce)
> - fix error handling in fallback skcipher allocation and remove pointless
>   memset()s (qce)
> 
> v2:
> - address issue found by build robot in patch #7
> - add patch #13
> - rebase onto cryptodev/master
> 
> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: John Allen <john.allen@amd.com>
> Cc: Ayush Sawal <ayush.sawal@chelsio.com>
> Cc: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
> Cc: Rohit Maheshwari <rohitm@chelsio.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Jamie Iles <jamie@jamieiles.com>
> Cc: Eric Biggers <ebiggers@google.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Horia Geantă <horia.geanta@nxp.com>
> 
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-amlogic@lists.infradead.org
> 
> Ard Biesheuvel (13):
>   crypto: amlogic-gxl - default to build as module
>   crypto: amlogic-gxl - permit async skcipher as fallback
>   crypto: omap-aes - permit asynchronous skcipher as fallback
>   crypto: sun4i - permit asynchronous skcipher as fallback
>   crypto: sun8i-ce - permit asynchronous skcipher as fallback
>   crypto: sun8i-ss - permit asynchronous skcipher as fallback
>   crypto: ccp - permit asynchronous skcipher as fallback
>   crypto: chelsio - permit asynchronous skcipher as fallback
>   crypto: mxs-dcp - permit asynchronous skcipher as fallback
>   crypto: picoxcell - permit asynchronous skcipher as fallback
>   crypto: qce - permit asynchronous skcipher as fallback
>   crypto: sahara - permit asynchronous skcipher as fallback
>   crypto: mediatek - use AES library for GCM key derivation
> 
>  drivers/crypto/Kconfig                        |  3 +-
>  .../allwinner/sun4i-ss/sun4i-ss-cipher.c      | 46 ++++-----
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss.h  |  3 +-
>  .../allwinner/sun8i-ce/sun8i-ce-cipher.c      | 41 ++++----
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h  |  8 +-
>  .../allwinner/sun8i-ss/sun8i-ss-cipher.c      | 39 ++++----
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h  | 26 ++---
>  drivers/crypto/amlogic/Kconfig                |  2 +-
>  drivers/crypto/amlogic/amlogic-gxl-cipher.c   | 27 +++---
>  drivers/crypto/amlogic/amlogic-gxl.h          |  3 +-
>  drivers/crypto/ccp/ccp-crypto-aes-xts.c       | 33 ++++---
>  drivers/crypto/ccp/ccp-crypto.h               |  4 +-
>  drivers/crypto/chelsio/chcr_algo.c            | 57 +++++------
>  drivers/crypto/chelsio/chcr_crypto.h          |  3 +-
>  drivers/crypto/mediatek/mtk-aes.c             | 63 ++----------
>  drivers/crypto/mxs-dcp.c                      | 33 +++----
>  drivers/crypto/omap-aes.c                     | 35 ++++---
>  drivers/crypto/omap-aes.h                     |  3 +-
>  drivers/crypto/picoxcell_crypto.c             | 38 ++++----
>  drivers/crypto/qce/cipher.h                   |  3 +-
>  drivers/crypto/qce/skcipher.c                 | 42 ++++----
>  drivers/crypto/sahara.c                       | 96 +++++++++----------
>  22 files changed, 280 insertions(+), 328 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt