Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Jul 2020 13:40:06 -0500
From:   John Allen <john.allen@amd.com>
To:     Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Bjorn Helgaas <bjorn@helgaas.com>,
        Vaibhav Gupta <vaibhav.varodek@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: ccp: sp-pci: use generic power management
Message-ID: <20200722184006.GA976732@mojo.amd.com>
References: <95db9ba2-ffbb-ca92-6a70-1ee401920eed@amd.com>
 <20200722093057.98551-1-vaibhavgupta40@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200722093057.98551-1-vaibhavgupta40@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mojo.amd.com (165.204.77.1) by SA9PR11CA0002.namprd11.prod.outlook.com (2603:10b6:806:6e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.19 via Frontend Transport; Wed, 22 Jul 2020 18:40:15 +0000
X-Originating-IP: [165.204.77.1]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 1439e25b-6e23-4b0a-7ec6-08d82e6ead42
X-MS-TrafficTypeDiagnostic: SN1PR12MB2592:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN1PR12MB2592225EE6CA41E67952CDBC9A790@SN1PR12MB2592.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ShKx+JT1Qz6fGEY+/BQaT6PAC7yJ+VhjRIUr0yitcnkNUfL2PZvg6VLFOMuc+aG+UgkfG/UO+RKX8FV+0bD3F154+/y2gUvwAbn/JEmKOh318/nxI+g3LfuPntQ8AgpTX1D9CHi1TYToHLk6C+srWCvY3gnoliEqgNtZ3jqySYGWbhcZoUUPFniaDqwAVeersZf0x7huHJk89ge/lUfJ+3XhJiWZrizj1Ve9YbVm5qxSlXzz0pH4zZLzxRjcaUwk+z3cnT2IcYpSGSrOn4UME5snxrnWC+/9i2nGQUcobgtBUaXqOROOwlbez48m19A5Yb/g0tJGLFJJRj0mawQTJ9nI7F/m1FegWBWvKSq0qEjp4qau0z3c9LIAVs3Nh04B
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR12MB2590.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(956004)(1076003)(54906003)(316002)(4326008)(2906002)(6916009)(16526019)(478600001)(86362001)(186003)(8676002)(33656002)(4744005)(66476007)(66556008)(55016002)(66946007)(5660300002)(8936002)(7416002)(44832011)(26005)(6666004)(7696005)(52116002)(41533002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: bomdCZ1g5XptjciVFkNeY8Qckkt6Om3xhBDfqGUccJTYrfCi2mJg1IzlrS0Q4hOIuHTRwYLQJZQLlQQ9EPeAAe+SwPqA2z7OGrQxQu5QfZEB3i2C65HxwbRxw4SPV57wSB/xgkndGXkaRTqnp+y366BC/S/KN10r9BtApSr4b+W9F0Fh/d1Jgvi2bqzohyqAiljhhxPdbR/ZMw+YA0KoBFfpWKfs1EQBh+hZbHM2iFTjI3tb4iP7a0fhCMb86wVIi9J8ovIu0SB2Zk/ORHOq+Y6WrDltWmzGNVANWnJQG3BhV9mJYU7Qaz2g49ZRXXMK40r77ll6gm2NVccmWX734UXeey6zxfLT2cty5RS12mbeQyjzbFAJ5yCM0embbD9dwZA5kgHvIcJ16SEvTk6wKM596bHnlX8wxlOooQLV/jDUHJjfj6qGOkmU0EHFHmHMV8r90ZKmN2xSsk1fU9AvSLr8Y/CsrV4nd1jE8dj0wNQ=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1439e25b-6e23-4b0a-7ec6-08d82e6ead42
X-MS-Exchange-CrossTenant-AuthSource: SN1PR12MB2590.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2020 18:40:16.3360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gStoGkqsQFoq0bC3jMwZgBK30OMeJaNml+7bZ8JPX5sBUAnXp4peA2fAeFYGp9AeWojszcnI0ujRtuIOg9uYng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2592
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Wed, Jul 22, 2020 at 03:00:58PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
> 
> Switch to generic power management framework using a single
> "struct dev_pm_ops" variable to take the unnecessary load from the driver.
> This also avoids the need for the driver to directly call most of the PCI
> helper functions and device power state control functions as through
> the generic framework, PCI Core takes care of the necessary operations,
> and drivers are required to do only device-specific jobs.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>

Acked-by: John Allen <john.allen@amd.com>