Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: Help getting aesni crypto patch upstream
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
References: <2a55b661-512b-9479-9fff-0f2e2a581765@candelatech.com>
 <CAMj1kXFwPPDfm1hvW+LgnfuPO-wfguTZ0NcLyeyesGeBcuDKGQ@mail.gmail.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <04d8e7e3-700b-44b2-e8f2-5126abf21a62@candelatech.com>
Date:   Wed, 29 Jul 2020 05:27:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAMj1kXFwPPDfm1hvW+LgnfuPO-wfguTZ0NcLyeyesGeBcuDKGQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 7/28/20 11:06 PM, Ard Biesheuvel wrote:
> On Wed, 29 Jul 2020 at 01:03, Ben Greear <greearb@candelatech.com> wrote:
>>
>> Hello,
>>
>> As part of my wifi test tool, I need to do decrypt AES on the CPU, and the only way this
>> performs well is to use aesni.  I've been using a patch for years that does this, but
>> recently somewhere between 5.4 and 5.7, the API I've been using has been removed.
>>
>> Would anyone be interested in getting this support upstream?  I'd be happy to pay for
>> the effort.
>>
>> Here is the patch in question:
>>
>> https://github.com/greearb/linux-ct-5.7/blob/master/wip/0001-crypto-aesni-add-ccm-aes-algorithm-implementation.patch
>>
>> Please keep me in CC, I'm not subscribed to this list.
>>
> 
> Hi Ben,
> 
> Recently, the x86 FPU handling was improved to remove the overhead of
> preserving/restoring of the register state, so the issue that this
> patch fixes may no longer exist. Did you try?
> 
> In any case, according to the commit log on that patch, the problem is
> in the MAC generation, so it might be better to add a cbcmac(aes)
> implementation only, and not duplicate all the CCM boilerplate.
> 

Hello,

I don't know all of the details, and do not understand the crypto subsystem,
but I am pretty sure that I need at least some of this patch.

If you can suggest a patch to try I'll be happy to test it to see how it
performs.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com