Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2481722ybg; Fri, 31 Jul 2020 00:24:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnrkhkDJemUkhkX08TalmHFV7Ys5Wo6Xc7dPccAnM8L9d8c8OpuAiFTEXkpqzBMQ0tTL09 X-Received: by 2002:a05:6402:1764:: with SMTP id da4mr2630340edb.187.1596180254055; Fri, 31 Jul 2020 00:24:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596180254; cv=none; d=google.com; s=arc-20160816; b=j1c/wspH1z4vL9z+bxmDHWG5XvLvcZGWxPVqgySUg1fKBcNzh8CRWxaeaDwO4VufYw 8XImnPWJJFvP2iUh5ETy5WGAw/jFyylORsmJDL4S69gNaJxTFXoMt+5tCl6bhyy+JX28 LsnuZlWN5Fd7m9Qrq/R/aGelCGBBveBaqp38BHHhOrPHl3LZXjv7hAtbqWTlzD98mDGs lg/YQyWCrDnPFBdidPHYzCkQsvgyMnSuL56zlEHS4bk6nCL7hZjhTapjSRKEzyOTKp9J jK8T0baTKP6y7lHcsKj6Q+NobS3q8Xi9HtgPLIw2wXPFyCJBqMixx0jcyuBtGW/djstq lsCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=kfeNuo8HejSFSCea6RrsRpO3bAy/IMVjjXFZeL7gH8E=; b=FsjId4qh8zC9QrojcvDvfwYkw5GNTgCNwmW1wopMrvbMDDdz7eJocUxIAVZyWfhFwT kxFSvfGT2Xr4apDTLphD+itn7C1+1XmXqkFGXLRSm6TZ+Xvgzss7afsh1XzCWAtfftx+ uW87PS58fRcb7LlyEB2SIgigJZN4hxjePmx+izIrAT3VRMzX2UKJeHxmZNvfIsVNnbpu M9kI7LXVeYgCMsW04GjWnuOWh8ToMhvR7RWw3jrQzbbQaJw89k5QO+rhOOd1wNHWKBkz 4b2in4gjBD1GINHh9mvMcrQahY7p7i5QucwzrT3iP/SRas/HB4z0pQUNEdtQp9DIgjU+ RWjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si4949492eds.380.2020.07.31.00.23.45; Fri, 31 Jul 2020 00:24:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731587AbgGaHXo (ORCPT + 99 others); Fri, 31 Jul 2020 03:23:44 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:39876 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731419AbgGaHXo (ORCPT ); Fri, 31 Jul 2020 03:23:44 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k1POE-0001Et-Aa; Fri, 31 Jul 2020 17:23:39 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 31 Jul 2020 17:23:38 +1000 Date: Fri, 31 Jul 2020 17:23:38 +1000 From: Herbert Xu To: Elena Petrova Cc: linux-crypto@vger.kernel.org, lenaptr@google.com, ebiggers@kernel.org, smueller@chronox.de, ardb@kernel.org, jeffv@google.com Subject: Re: [PATCH v4] crypto: af_alg - add extra parameters for DRBG interface Message-ID: <20200731072338.GA17285@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729154501.2461888-1-lenaptr@google.com> X-Newsgroups: apana.lists.os.linux.cryptoapi User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Elena Petrova wrote: > > +#ifdef CONFIG_CRYPTO_USER_API_CAVP_DRBG > +static int rng_setentropy(void *private, const u8 *entropy, unsigned int len) Please use __maybe_unused instead of the ifdef. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt