Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2526787pxa; Mon, 3 Aug 2020 19:21:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzHfeLppNnWOnD4f7q82e51KMBm58Ro0bJZeHa2KdiaSP/PA0VLLoFvvBKekZUnNsvmBWE X-Received: by 2002:a17:906:1c84:: with SMTP id g4mr20315073ejh.50.1596507665858; Mon, 03 Aug 2020 19:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596507665; cv=none; d=google.com; s=arc-20160816; b=KbqW/alBh/sNK4foM3Znn9YkiVSzFiX0lldAYYF7U61grTgjAwbTuTko4TwHVnTC8c UVvhXdein0k335n6FJcpaiGdgm+oBp64VHWzFXBj0vF2nTIOGrQzNep6u8z2Zfp78dX9 E/WqwT+nNBxe0DDMtGtEwFySsrHfkK0MO+l7dxZkEtWUe+H7OVQrAdLxFHAvvCsPkyc6 FN6aI0yfu57uVwpi6MFnC3RAg9LXDwV/KWNrvB4ITkSYaWtC8JpxpICKrPlDTWmUNJgF 75V6bAvWmmm6I1CdSy/Q9dQNQF5CVbgdnCIhL5esRyHUDghAq4exlHWmp2lTmCfBNKDY kI9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=x6vyFWqkuibEs66WG0ofkIhjZzq6NL9eAQXoCSXHqPo=; b=c9NGSZEoHHFMItgztH0RaVSx5NOKE4JU6G6I0zdgiE3osW0rz8HRNYf525csN6Hu4o sYp04D2IqhpV11a2j3rhH1hM9WPZ2XXjCiT6VaOmpoCGuguIjoYkzAeoldOV+txsVBkZ yGMKeDxLDkfvjNHR59o1zPEVUc1uxVD67hev0mCaIOPbIpFSyjPjNX6sLzLvL0VFXa6J U3sF8qL1LudedtVf9NdSc0TmMcQhHO+2ec41WpuhK6d2Os0j/9nCopIpMyBKz1GT3Eva jcYwwu+vAd+Z+26LnuIvN4xcPVL3qJQoObQ89+3C0rlIgA+8RCmlOtQLBQk7vebzn9Qs mtjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si11088269eds.470.2020.08.03.19.20.28; Mon, 03 Aug 2020 19:21:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728244AbgHDCSQ (ORCPT + 99 others); Mon, 3 Aug 2020 22:18:16 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:54370 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727978AbgHDCSQ (ORCPT ); Mon, 3 Aug 2020 22:18:16 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k2mWo-0006YH-Ew; Tue, 04 Aug 2020 12:18:11 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 04 Aug 2020 12:18:10 +1000 Date: Tue, 4 Aug 2020 12:18:10 +1000 From: Herbert Xu To: Elena Petrova Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Eric Biggers , Stephan Mueller , Ard Biesheuvel , Jeffrey Vander Stoep Subject: Re: [PATCH v4] crypto: af_alg - add extra parameters for DRBG interface Message-ID: <20200804021810.GA10584@gondor.apana.org.au> References: <20200729154501.2461888-1-lenaptr@google.com> <20200731072338.GA17285@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 03, 2020 at 03:48:02PM +0100, Elena Petrova wrote: > > sendmsg is used for "Additional Data" input, and unlike entropy, it > could be useful outside of testing. But if you confirm it's not > useful, then yes, I can decouple the testing parts. Unless there is someone asking for it then I'd rather not export it to user-space. > Depends on the comment above, but otherwise, my only concern is that > the testing variant of rng_recvmsg would be largely copy-pasted from > the normal rng_recvmsg, apart from a few lines of lock/release and > crypto_rng_generate/crypto_rng_get_bytes. They could certainly share code through the use of functions. Chers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt