Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1947480pxa; Thu, 6 Aug 2020 21:55:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx22rEkfjUwOokYkQOsxEdMUqf/PHykKs/rmBMiS1LFeMKfZFlJJRXr/UZy1nmhmItmMbGe X-Received: by 2002:aa7:d654:: with SMTP id v20mr7254846edr.314.1596776125874; Thu, 06 Aug 2020 21:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596776125; cv=none; d=google.com; s=arc-20160816; b=gQQPkqxDvdW47xq3DCX4M9/hhNmjMa7UKxAHhbCXgrvu6c4LNLU1sxtlAYi4LSUL+Z UTx2JNVb2qwuAFJOHtasakyOavfSVolF3Am9mDixamqE1jBD5Sumbmw1xYxcqZ98itoz q8FQttZ/WcZs7vN0uee6e3Co0DRdftwT4dJObfsbREowybo9XSGyZmYf/1GcU0gOGPyE zbk6qTEhsfBKKZTf22E2XxxtatM/tcjl8QVgKWZeIFC54Tr2JPwXJhkw133OsTkcwLMH htCj53UjGhXPL78eth5RZyNudhH00cWE2SoBCdt6HCtMzwu2A4b7T5aKEWVxdCaCjgDx aNvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=BUsEENNi8m1esi2CN3aVyMsHIk3sOIeBlDrwkL+KRQI=; b=EnJNkdNCQcRcAPjc+u44c+dGmcWsEJg45qlps2TkbQlaAm6FmEBWF4RhxERYQT7Hbm TNor15tx/gJU3pMUKo1vQvLO6u0MYaroh5Y5UNhnXMz9h3tO1uNUs0h46XXLUjEBdxXC aTFP4r+8xlo0i/Gb3a6pbWbR9i00ey1vtNF6fXlGcdM41Ug/FL7MzEAXKj763OJFy3Lw Il6cSTysPQqIbG4P1gRKvQuGK5dACUkreWlxFZIocKyN70I0nthTqRD5NKLh3TG7LrF+ mxksjixMCskEiVFwuciMG7EDQ/5XwSSSXAzHex8jVI0CKEjHujS/9mHdlPwraCOVAriT aOVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz17si4481094ejb.63.2020.08.06.21.54.47; Thu, 06 Aug 2020 21:55:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725287AbgHGEy3 (ORCPT + 99 others); Fri, 7 Aug 2020 00:54:29 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35256 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbgHGEy3 (ORCPT ); Fri, 7 Aug 2020 00:54:29 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k3uOe-0004FA-Kr; Fri, 07 Aug 2020 14:54:25 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 07 Aug 2020 14:54:24 +1000 Date: Fri, 7 Aug 2020 14:54:24 +1000 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Aymen Sghaier , Linux Crypto Mailing List Subject: Re: [v3 PATCH] crypto: caam - Move debugfs fops into standalone file Message-ID: <20200807045424.GA24062@gondor.apana.org.au> References: <20200730135426.GA13682@gondor.apana.org.au> <20200801124249.GA18580@gondor.apana.org.au> <20200806221005.GA22325@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200806221005.GA22325@gondor.apana.org.au> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 07, 2020 at 08:10:05AM +1000, Herbert Xu wrote: > On Thu, Aug 06, 2020 at 09:09:49PM +0300, Horia Geantă wrote: > > > > I'd rather move these in the newly-created debugfs.c, see below v3. > > I'd rather not because this creates more ifdefs. Actually I take that back. This does seem to be nicer than my patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt