Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] crypto: ingenic - Drop kfree for memory allocated with
 devm_kzalloc
To:     Wei Yongjun <weiyongjun1@huawei.com>, mpm@selenic.com,
        herbert@gondor.apana.org.au, arnd@arndb.de,
        gregkh@linuxfoundation.org, prasannatsmkumar@gmail.com
Cc:     linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
References: <20200804081153.45342-1-weiyongjun1@huawei.com>
From:   Zhou Yanjie <zhouyanjie@wanyeetech.com>
Message-ID: <dc81addf-28db-72ef-1181-5b6425374e3c@wanyeetech.com>
Date:   Fri, 7 Aug 2020 23:57:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20200804081153.45342-1-weiyongjun1@huawei.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hello,

?? 2020/8/4 ????4:11, Wei Yongjun д??:
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.


Thanks for fix it.

Reviewed-by: ?????? (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

>
> Fixes: 190873a0ea45 ("crypto: ingenic - Add hardware RNG for Ingenic JZ4780 and X1000")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   drivers/char/hw_random/ingenic-rng.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/char/hw_random/ingenic-rng.c b/drivers/char/hw_random/ingenic-rng.c
> index d704cef64b64..055cfe59f519 100644
> --- a/drivers/char/hw_random/ingenic-rng.c
> +++ b/drivers/char/hw_random/ingenic-rng.c
> @@ -92,8 +92,7 @@ static int ingenic_rng_probe(struct platform_device *pdev)
>   	priv->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(priv->base)) {
>   		pr_err("%s: Failed to map RNG registers\n", __func__);
> -		ret = PTR_ERR(priv->base);
> -		goto err_free_rng;
> +		return PTR_ERR(priv->base);
>   	}
>   
>   	priv->version = (enum ingenic_rng_version)of_device_get_match_data(&pdev->dev);
> @@ -106,17 +105,13 @@ static int ingenic_rng_probe(struct platform_device *pdev)
>   	ret = hwrng_register(&priv->rng);
>   	if (ret) {
>   		dev_err(&pdev->dev, "Failed to register hwrng\n");
> -		goto err_free_rng;
> +		return ret;
>   	}
>   
>   	platform_set_drvdata(pdev, priv);
>   
>   	dev_info(&pdev->dev, "Ingenic RNG driver registered\n");
>   	return 0;
> -
> -err_free_rng:
> -	kfree(priv);
> -	return ret;
>   }
>   
>   static int ingenic_rng_remove(struct platform_device *pdev)
>
>