Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andrei Botila <andrei.botila@oss.nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, x86@kernel.org,
        linux-arm-kernel@axis.com, Andrei Botila <andrei.botila@nxp.com>
Subject: [PATCH 09/22] crypto: xts - add check for block length equal to zero
Date:   Fri,  7 Aug 2020 19:19:57 +0300
Message-Id: <20200807162010.18979-10-andrei.botila@oss.nxp.com>
In-Reply-To: <20200807162010.18979-1-andrei.botila@oss.nxp.com>
References: <20200807162010.18979-1-andrei.botila@oss.nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from lsv15007.swis.ro-buh01.nxp.com (83.217.231.2) by AM0PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:208:be::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15 via Frontend Transport; Fri, 7 Aug 2020 16:21:57 +0000
X-Mailer: git-send-email 2.17.1
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 4ad53ed7-587f-40a5-45ad-08d83aee01bd
X-MS-TrafficTypeDiagnostic: VE1PR04MB7359:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VE1PR04MB73594F9175A3E0D172D15333B4490@VE1PR04MB7359.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rOh5w+s9PqbXc2jcZ1BQLHyncDirxVRD4jdekA7Syfswt/w/ROIwz/cJnzIzH4WUvJiZDv0QulE7Htc5MIKD602XM1VY8VMzU0g80LoPLGYHzt7/7UJVAFxNq5eIR5GcWId6Zb3M58Nca7paq3+lYFbCCFfNxd7vcU9NSI47TynJBU1d1DR7jgluWq3DOFc7pUyZ9H0briBJCZOHMoyzxDevONO8tskb9XLuh+i6ExZN1GEtzW4bQ+14PZZ2detPLy2CqGUuAA6DrTIHkaOiM+uXccbLMucwAWRh69r9e7LJ/iBmTZo+Zm5Tgu6L5rWlbZeVZ+MGCpIscCuREStLzA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6608.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(44832011)(66556008)(66476007)(110136005)(1076003)(6506007)(4326008)(66946007)(83380400001)(8936002)(316002)(26005)(956004)(186003)(16526019)(478600001)(4744005)(86362001)(5660300002)(6512007)(2906002)(8676002)(2616005)(52116002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: KaITC/4v2sf7hi3vwd2JC2khaf5a+VUGJVbtTSg1JvE+/UgxSV0teMtOWwpmFdj6PK4SsqmbfsrWQMoGStJCx5ciuBlGCOI6wfJqjVUfxOpYVLa+pXYuzuDrM3Y/R4eMsA80UUPvbMOK3MEb1hMo6Q11G6n65UOZ/bKt0QQLIEnDN6ps/gP8Jrxdyt6hefAddwhcrLnxqJEHIRipw9s0SfBMoLKUnAsXCE2h7KnuLwdddY5aqCDw7kgKaJ6A0D54YrhdzDY9YHfQcUCJzhiQnzW1r7Q3OEhjJwKkFyuc9DyKtg2U4g+T0cbxXUZuphI0RMXRz7dsbcKEYggaj/f6jvio15VSnw1nIV5Z5ay7I1LdmarIb+twu8m7sBVKhc9w4FrPZdcjPwpO9iDl3zx6C9724YEW/Mt664ZnGnYMdP6iuJ2Z4X9oPUlsUffm5bzdBNA4md4EMHFpEDpmJxBq/1zIJcMHKWfnZlkywYSrWvcth3d9N0RQCAA+nMQsEBpP2kXq0wa+kxfNlg7kZsYqXA/fp0xwGOz9cmfMQjUmbTrgU4Z3Xc3P80P1Z2q+p99Zq4dS7vAWHEj18/whPxfTTwHJk/6dW79jHXDLfNCT2XyC2NMPMKBrYv+oVvKD0puy3g5I16KT82UffZZsLWDvCw==
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad53ed7-587f-40a5-45ad-08d83aee01bd
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6608.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2020 16:21:58.0772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mtzUDYpUxJDKeTHPmLQUJkyRjx+dqPhfHgSxMbe+Yb8h5Sh/MODD5fjBLixfwETkmiHrs/8IXe3CM5PEtXreTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7359
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

From: Andrei Botila <andrei.botila@nxp.com>

Standardize the way input lengths equal to 0 are handled in all skcipher
algorithms. All the algorithms return 0 for input lengths equal to zero.

Signed-off-by: Andrei Botila <andrei.botila@nxp.com>
---
 crypto/xts.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/crypto/xts.c b/crypto/xts.c
index 3c3ed02c7663..7df68f52fddc 100644
--- a/crypto/xts.c
+++ b/crypto/xts.c
@@ -263,6 +263,9 @@ static int xts_encrypt(struct skcipher_request *req)
 	struct skcipher_request *subreq = &rctx->subreq;
 	int err;
 
+	if (!req->cryptlen)
+		return 0;
+
 	err = xts_init_crypt(req, xts_encrypt_done) ?:
 	      xts_xor_tweak_pre(req, true) ?:
 	      crypto_skcipher_encrypt(subreq) ?:
@@ -280,6 +283,9 @@ static int xts_decrypt(struct skcipher_request *req)
 	struct skcipher_request *subreq = &rctx->subreq;
 	int err;
 
+	if (!req->cryptlen)
+		return 0;
+
 	err = xts_init_crypt(req, xts_decrypt_done) ?:
 	      xts_xor_tweak_pre(req, false) ?:
 	      crypto_skcipher_decrypt(subreq) ?:
-- 
2.17.1