Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 Aug 2020 17:11:48 +1000
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ondrej Mosnacek <omosnace@redhat.com>
Cc:     linux-crypto@vger.kernel.org, Stephan Mueller <smueller@chronox.de>
Subject: Re: [PATCH v2] crypto: algif_aead - fix uninitialized ctx->init
Message-ID: <20200813071148.GA3894@gondor.apana.org.au>
References: <20200812125825.436733-1-omosnace@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200812125825.436733-1-omosnace@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 02:58:25PM +0200, Ondrej Mosnacek wrote:
> In skcipher_accept_parent_nokey() the whole af_alg_ctx structure is
> cleared by memset() after allocation, so add such memset() also to
> aead_accept_parent_nokey() so that the new "init" field is also
> initialized to zero. Without that the initial ctx->init checks might
> randomly return true and cause errors.
> 
> While there, also remove the redundant zero assignments in both
> functions.
> 
> Found via libkcapi testsuite.
> 
> Cc: Stephan Mueller <smueller@chronox.de>
> Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when ctx->more is zero")
> Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> 
> v2:
>  - intead add missing memset() to algif_aead and remove the redundant
>    zero assignments (suggested by Herbert)
> 
>  crypto/algif_aead.c     | 6 ------
>  crypto/algif_skcipher.c | 7 +------
>  2 files changed, 1 insertion(+), 12 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt