Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200713172511.GB722906@gmail.com> <20200731072654.GA17312@gondor.apana.org.au>
In-Reply-To: <20200731072654.GA17312@gondor.apana.org.au>
From:   Elena Petrova <lenaptr@google.com>
Date:   Thu, 13 Aug 2020 17:00:27 +0100
Message-ID: <CABvBcwbQY9nnDu5LSRUDHqPcmnedwa-juQaFdirDY3zTuZB0yA@mail.gmail.com>
Subject: Re: [PATCH 1/1] crypto: af_alg - add extra parameters for DRBG interface
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Eric Biggers <ebiggers@kernel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi Herbert,

On Fri, 31 Jul 2020 at 08:27, Herbert Xu <herbert@gondor.apana.org.au> wrot=
e:
>
> How about you fork the code in rng_accept_parent so that you have
> a separate proto_ops for the test path that is used only if
> setentropy has been called? That way all of this code could
> magically go away if the CONFIG option wasn't set.

I tried doing `ask->type->ops =3D &algif_rng_test_ops;` in
accept_parent, to which the compiler complained "error: assignment of
member =E2=80=98ops=E2=80=99 in read-only object". So I'm setting `.ops` ac=
cordingly
at compile-time instead, together with `.setentropy`, in v5.