Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3110012pxa; Tue, 18 Aug 2020 06:56:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLhPjEJQBL5NNO3thGc7rlnLqKVCn0hPJVB1OxBxBEwJ+yIy4EJVLIE46/sCkW2nbqTLHx X-Received: by 2002:a50:c449:: with SMTP id w9mr20596252edf.65.1597759003864; Tue, 18 Aug 2020 06:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597759003; cv=none; d=google.com; s=arc-20160816; b=FtPCFk3J87WMQYgjXviHDe2mr5cX6rPf6yjrk5+lzB9ZWFLP7350C740hnSUTXqOru 7xQN31okJCIZDBkUtyO2RLYueInee25mn4glbkMZF1YzZCdLrN4hWbHTnij/2GneNybl EtbrxX19OMVBe/2/lwe6D8QaWyszgiTJyIPTLLPtCacXcEEk6KQm26eUqwG/ccMwPiKf fVjjyJEV70BquCJ2/QFqKQEYUT9gCUdOroXTdkUNyoR0Rqlxr6i+SRSzOisgNWNNOgwD xcJxEG08XcGhScEBGdednzYkgmqvMO87Z4+IELmCIDZt5nWNBCncPsI+A3xBc6CcZ9U2 o4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:dkim-filter; bh=zPQtMg7ppZECzzlyfB9jCXn/jByO4Xp6pJwIPOQAdvY=; b=Izgdkj80dcXHQ8L2UagXlKESVT0J4+R3lmkrBTtnt2ncSBlU5mPfNE8XKJVIMzDR3Y XSf3WGOkuhduhpQ1LplLSHuU79NXrIThJeJH6rJs2dT7YIDVwdgW/DsUpVrvkFE1+Xg3 IKugVGdLzteUNMNUOar0vTDD83iYfKZjxSfBJq9VkBV5rLc6fy+Cxfl0BUHoJiihWv+6 BpTQwfixfGhPKPxR2Tvm+LH6Z9CPQvT2nvrOnj0madVZ6eG4OtgOelO1+PQdB/MVplxF ULYOol4BwITFt/9yttc3uv9YCSoLgFMETR9V0aE0oqQb7fJoaFluehjkY0VeKJ04ddOb aqIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=QAgrJVY2; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gq5si13345555ejb.162.2020.08.18.06.56.19; Tue, 18 Aug 2020 06:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=QAgrJVY2; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgHRN4S (ORCPT + 99 others); Tue, 18 Aug 2020 09:56:18 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:37596 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgHRN4Q (ORCPT ); Tue, 18 Aug 2020 09:56:16 -0400 Received: from [192.168.254.6] (unknown [50.34.202.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 97D5F13C2B0; Tue, 18 Aug 2020 06:56:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 97D5F13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1597758973; bh=h6tkVxAlbm3mBbnxPCxhv+aa86rZjfk2i0BeaR+ghUA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QAgrJVY247YXueqOYPzwpvvWMYlniv03RlFoRHUJ+vTPpd7YjbOhVyKLeSyZJY2r+ mmI+aAHCRJ+Fg4xZOYqZ6eE2zGom5WKcSJqjJjEgZIyOl1GFaMQfje82C5+Ezq0Fnt EOxZsZ3kAbvOYUwULiA/gkcgtaSLfAGJ9SuMkffQ= Subject: Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher To: Herbert Xu , Ard Biesheuvel Cc: Linux Crypto Mailing List , Eric Biggers References: <20200802090616.1328-1-ardb@kernel.org> <20200818082410.GA24497@gondor.apana.org.au> <20200818135128.GA25652@gondor.apana.org.au> From: Ben Greear Organization: Candela Technologies Message-ID: <2aad9569-877e-4398-88ef-e40d9bbf7656@candelatech.com> Date: Tue, 18 Aug 2020 06:56:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200818135128.GA25652@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 8/18/20 6:51 AM, Herbert Xu wrote: > On Tue, Aug 18, 2020 at 10:31:39AM +0200, Ard Biesheuvel wrote: >> >> What do you mean? You cannot implement cbcmac using a cbc skcipher >> unless you provide a scratch buffer of arbitrary size as the >> destination, in order to capture the skcipher output IV as the MAC. > > Please have a look at patch 6. The trick is to use an SG list > chained to itself. Herbert, thanks for working on this. If I apply the patches you posted, that is expected to provide wifi aes decryption speedup similar to what the original patch I sent does? Or, are additional patches needed? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com