Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3408799pxa; Tue, 25 Aug 2020 22:24:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0OGm3GERvIRgZTU5zhZ5CfOOwrSn7Z16kINzE/tOZYrKgw+xwooGEVIxYYzWp8IZSwIfF X-Received: by 2002:a17:906:f143:: with SMTP id gw3mr14797339ejb.125.1598419445824; Tue, 25 Aug 2020 22:24:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598419445; cv=none; d=google.com; s=arc-20160816; b=bNj/VymfFzKR+x/2SOhCz78+n0L/VlFTlW1yB/I8KzORo/9Z/QLcNfeU1qYZ19D20l L7orwZtvxwhxXqmvwysjjYaYfV84vfx7WjcufIfNcOQ4Q7u+0dyo5sbq/CgkI3uyG6Oc aOI0aPcQbGzhkRvaXTe/mkd+52t+zbG4HPrSNeNuBiaAWohwBpQddtiWgbPeGrnbFwLE Jt/GISnKae7MOOUX/npBayLd4vfr/d3G7toTmP3ypkBY87fsREKPij5TpjHT6pBEHYKt OzcH5fiC4oady68uFksUOquuf16HZeCaaRXaAdY/jmw5LXmn+/tDOJAEnjNUp4m+hVct NYgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dTsMwQU3eVZt3RKaNpwezO3ue3PVVm4YHGjPcdSi/eg=; b=shgdKeh20e0iFNGMis2jlHWoZlEjnCmdU5Y8VHsX9k/g47h9aZ5+YcnxhYqNWWepIl aU0DjImD28LNnoX1F3vOtreuKbBrjZgEWMapuc4njlaNRCRFThWLsLBNTifvC8S4YRKB 9t1goxzupsy2PHIDCY/+olWml8SfCz8mpJpozFglGPfJdnCJXqgO4huSRPjMQY9rsp6M 3H9RdXdeK5iTCVv5FYgqgV2o18oZPQ5k5V3a8Dp12Rfx94pqNuHTfju8pcMqHo717UTy V1BsUr/fKPvGbrRVTGlzXDBCN2uf+2syZmbHfGbAymC3qMzhW7NBce61ZEtq9vmgHYfD +0KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hqt2kgu+; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si868448eja.559.2020.08.25.22.23.29; Tue, 25 Aug 2020 22:24:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hqt2kgu+; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725786AbgHZFX1 (ORCPT + 99 others); Wed, 26 Aug 2020 01:23:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgHZFX0 (ORCPT ); Wed, 26 Aug 2020 01:23:26 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B788C061574 for ; Tue, 25 Aug 2020 22:23:26 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id v1so247403qvn.3 for ; Tue, 25 Aug 2020 22:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dTsMwQU3eVZt3RKaNpwezO3ue3PVVm4YHGjPcdSi/eg=; b=hqt2kgu+BldltBIEBE4hpQRWSvPlopG8LTpD3ZYJBcNNXhxI54bV9ULHRtRXP6578y vetEfAEBBjHAJPAF3GW0wRBsy2/ftPLijxtIqUPSurPjFVz1f+mK7Ey9lTSBN05ixuXN SI2Hr6k/podDwvV/+tO47+zktUfgVcvkv0j83iFF/WXba/C6o4pyJNgXI8H2urUfYByi KsJA5cMi9jbWmVI0G0S6XEzfB9dRkWq1KQaHNnPoHY5MUnK+N9WguC1CQd/nZestkJiD OflBXvdwSH47GDQ03Bk2PdfQL3EQRUEoeTk5tFqkZrh5vyH14IT7bveof6vxkZldtE3/ zesA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dTsMwQU3eVZt3RKaNpwezO3ue3PVVm4YHGjPcdSi/eg=; b=Nc1PYlYdj1QA40CHDLtlkknF1peflQajAFWfWdOL2iyn1MzmFnyl2RhzEiRfPsN0c7 nia7ElPvHFaJ7VMT6mm2tqLbkjxkCXZRrjaZYlPpsgRI+J08p8fhJmq5jZBZiEyV/TuK qMSl3dytXOmN0yj5bt+1rvaMCCnppOwMTVnVscRhYjczJgaVKJOVS9/Qw+qp4t3U2uL/ qDzZq66oefXSfp03hO4iuUbZP1l/gZrOiC2hehnmObGdhwBOdpLMrqhQRoE6yU0Fi8qB wpUw4lS01TI4/BCmZY5Vy117BahGUQl3kyS6x3LAMCLS9AO/eHKNvfBo2woVNKUy8t8j vKVg== X-Gm-Message-State: AOAM530ZPpGJIbLm44PHKaUWKBC04panWjt7VXjoJ49el2q6LYrr7Ykd iBVCPuka1U02SIDcmfwviaI= X-Received: by 2002:a0c:f1c9:: with SMTP id u9mr12603983qvl.76.1598419405752; Tue, 25 Aug 2020 22:23:25 -0700 (PDT) Received: from ubuntu-n2-xlarge-x86 ([2604:1380:45d1:2600::1]) by smtp.gmail.com with ESMTPSA id d20sm876200qkk.84.2020.08.25.22.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 22:23:25 -0700 (PDT) Date: Tue, 25 Aug 2020 22:23:23 -0700 From: Nathan Chancellor To: Tero Kristo Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org Subject: Re: [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang Message-ID: <20200826052323.GA1906591@ubuntu-n2-xlarge-x86> References: <20200825133106.21542-1-t-kristo@ti.com> <20200825133106.21542-3-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825133106.21542-3-t-kristo@ti.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 25, 2020 at 04:31:06PM +0300, Tero Kristo wrote: > Clang detects a warning for an assignment that doesn't really do > anything. Fix this by removing the offending piece of code. > > Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") > Reported-by: Nathan Chancellor > Signed-off-by: Tero Kristo Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor # build > --- > drivers/crypto/sa2ul.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c > index 5bc099052bd2..ff8bbdb4d235 100644 > --- a/drivers/crypto/sa2ul.c > +++ b/drivers/crypto/sa2ul.c > @@ -1148,12 +1148,10 @@ static int sa_run(struct sa_req *req) > ret = sg_split(req->dst, mapped_dst_nents, 0, 1, > &split_size, &dst, &dst_nents, > gfp_flags); > - if (ret) { > - dst_nents = dst_nents; > + if (ret) > dst = req->dst; > - } else { > + else > rxd->split_dst_sg = dst; > - } > } > } > > -- > 2.17.1 > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki