Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp985458pxa; Thu, 27 Aug 2020 23:49:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf6N5hnEKKXcFqGuaVHAMB5CoRBi+fvrcGMNUrUmhRyz7IvBasjjs+HjUx3Nnw6S6VGceq X-Received: by 2002:a05:6402:17ab:: with SMTP id j11mr417492edy.28.1598597342196; Thu, 27 Aug 2020 23:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598597342; cv=none; d=google.com; s=arc-20160816; b=RDBCCXOj33UGacJO/qaGRGPE7Oe+sgjYw5aETzAXZ9voaHJSIGy1adIUgayy7wkMkl /SsrrlsmXfn9VeBb9RfCVTJ/jzMCCvRDfnF8ZNZjdOmobcnO3hWwRd50CNT0JCNTNQxl eWvqgUf3ZNml51KIqyxtx39lLijVr+toAcCByBv8oPvP94JED/pt2Zkfv3Lnv0cbUi4e Kz6xydofgkR0wakhgH3Gz1CYiNQaInVjUBawvoFb93rcxE9/MpBlU9iciBPuYMfYaCfa OByjYG3poTlIJQ3HNlgoj7XEYyrt1+sTxI2SK5Rw4tOsRdtvuhGoR1Lecjt8ozJvySVn Mhyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VEvXE2q1tcgQTsqcG8fPnnIoMVpleWbvltwFFOnmuJg=; b=lF9SMOmxnsUs8L2DqFPPpLhEC3KOVjFYGFde1rwygok8CtnnEm/tnLDbUy0ZVNjKx5 1D3JaJ7mIUtWOkTJxWPtDQdS30om5PmxASYKOwAcnE+4Nx44Sw2Hu9Q+yKi7bgGKsqWU NNAVaVYZpOJ9cKS7pocomU3jDg1Ia5zXrJ5NOySOIZ2+YFmavfwH0MJObpc2QmwBzHnz oTSam4MAVoLGGosgp7riA+u1g6SxxTGKKoVuD+JRxW4/Up5pUhh6XtCNOoDa+SUVCnEj /3L7XKzp4y3yjFImbURm26ve08n5xw1+vfKdMMA/GKBWxK0ZDOd6HuAgh4kt0jjwnHue U6TA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si56360ejo.533.2020.08.27.23.48.22; Thu, 27 Aug 2020 23:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbgH1GsN (ORCPT + 99 others); Fri, 28 Aug 2020 02:48:13 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35202 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgH1GsN (ORCPT ); Fri, 28 Aug 2020 02:48:13 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kBYAv-0003Db-Na; Fri, 28 Aug 2020 16:47:50 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 28 Aug 2020 16:47:49 +1000 Date: Fri, 28 Aug 2020 16:47:49 +1000 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 03/18] crypto: sun8i-ss: support hash algorithms Message-ID: <20200828064749.GA26312@gondor.apana.org.au> References: <1598017415-39059-1-git-send-email-clabbe@baylibre.com> <1598017415-39059-4-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598017415-39059-4-git-send-email-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 21, 2020 at 01:43:20PM +0000, Corentin Labbe wrote: > > + err = pm_runtime_get_sync(op->ss->dev); > + if (err < 0) > + goto error_pm; > + return 0; You need to handle the error case like this: https://patchwork.kernel.org/patch/11728595/ Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt