Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp801916pxk; Mon, 31 Aug 2020 01:01:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkv6WqTFY4/OzNjJkx30ryqKFd0c4zkgnC36cIsexok/2eeDkzd9IpU70I1oE4ITN6rXc6 X-Received: by 2002:a17:906:cf82:: with SMTP id um2mr13398ejb.49.1598860896684; Mon, 31 Aug 2020 01:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598860896; cv=none; d=google.com; s=arc-20160816; b=KdCQexgoGZSaS5aM7qXn8dljfMNtA0smaX7fG6sBja+YtQvKzTxCfNQwk8FxjMz6q4 X44RM/dPrnSMK0XQgFDpfals7FPGjyI+fwu1gO1CoApJkXrwJZ1HLg2Upkr6DRj+2UfZ gxTYm23hfDD5YXQYADvsGF7NtOcxHQ1gvBCrSnJdl1RqD0KJXUil3NH/jlJzECwtWKx2 V+Jbdhec9Ul4ugcosqF6g9cU4TkqE0UrUNjYmYq7INqfQ/Oeqkjwt7DuRrAmRCgy6Pm/ PugDQq4Uxzh22BCiCdNyNW42rMO3tVJB7w12yDwhJd4y6EWiSaj9mTwDt2yzVcZRReg/ vtpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=fQaedDeDSQw3/zOgdtJl2CjhlzYSz5Ve9oW5heo1sSI=; b=vFjjWiKO7WaOE9YxYq4gGCe8JDHZe7RbVBocpsCNlgKYE0X6PumiPDfM7llclPa+KZ d1j6AU+A7fp55/FYfRfzNs0nD8Da/l05PThWU5A4igHFGNCZdyr/th8cyd20P02DUKnO itijVvAbJbaaOpfeWgStdqcToJXWuEjmMWMvjKj9xt+nopeexVb7wxeeraRBMZUfp9PA HQjD/98Pi4ecPhYC45/VZ8SXDpiWj2eVrPVQ5W4rKLf5VggDYCFufYZ+EsholTRzeRNm 2NI+V1fwfC6y4ABQapNfYFr/QgqOWGMeNEancpL70HGzZ0onYYVDAkvwfh/rXlJv4q5e 82Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r5si4777027edx.458.2020.08.31.01.01.03; Mon, 31 Aug 2020 01:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726102AbgHaH6i (ORCPT + 99 others); Mon, 31 Aug 2020 03:58:38 -0400 Received: from mga03.intel.com ([134.134.136.65]:62616 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbgHaH6h (ORCPT ); Mon, 31 Aug 2020 03:58:37 -0400 IronPort-SDR: baiI939K1RhwoPtqmcGzHyVdM+rViDOkevo3zkfdp8YcpHvJ4Q32a8yIq15/4TD7HSyNMvmyG5 OfR1rZr6AyAg== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="156929894" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="156929894" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 00:58:36 -0700 IronPort-SDR: /NfLvcjH14ZxGm0bjGvZtBi23J0r4BzRnKBPaTH8WA+1cxJzzC4R9RTsgKlXD8UBALK0lhK0Eh EWADzHXlNOKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="330614201" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 31 Aug 2020 00:58:34 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A98E9FA; Mon, 31 Aug 2020 10:58:33 +0300 (EEST) From: Andy Shevchenko To: =?UTF-8?q?Horia=20Geant=C4=83?= , Aymen Sghaier , linux-crypto@vger.kernel.org, "David S. Miller" , Andrey Smirnov Cc: Andy Shevchenko Subject: [PATCH v1] crypto: caam - use traditional error check pattern Date: Mon, 31 Aug 2020 10:58:32 +0300 Message-Id: <20200831075832.3827-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Use traditional error check pattern ret = ...; if (ret) return ret; ... instead of checking error code to be 0. Signed-off-by: Andy Shevchenko --- drivers/crypto/caam/ctrl.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index 65de57f169d9..25785404a58e 100644 --- a/drivers/crypto/caam/ctrl.c +++ b/drivers/crypto/caam/ctrl.c @@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask, kfree(desc); - if (!ret) - ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, - ctrldev); + if (ret) + return ret; - return ret; + return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev); } /* -- 2.28.0