Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1664160pxk; Tue, 1 Sep 2020 04:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWQtMmGZnPlTixT8aF9Y8CSBLFDXmBTs0LZReLYGhbnkDibYwqYAkV/R1Prcv20ZnbDE7x X-Received: by 2002:a17:906:7752:: with SMTP id o18mr1093454ejn.150.1598961042190; Tue, 01 Sep 2020 04:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598961042; cv=none; d=google.com; s=arc-20160816; b=pgwFxBpyXVxTFMiTg8hushY0gsNZx7d5bKNQxtLyob7/t9oKMZq3T508GlgEpUxA5H bN1hb2IsbCZkTO+djpwT3loSrMlmNpoSfN84EZjrYd/sO3P96j7bh+uGkcaYsDR5Wubm T6gLwh6lLCtUMeRxqZflknmwIj4ATlCAv/S8zaF81SMgKF8x8AGiFv/lFuPs+apj/wKv HY82jI/pMsonQuSGu3sixuHhjg+T5V6Sx7+heMZR/cAWycs1Cs001px/1uNnhF5Kx9C7 VnIrRoILdgF9VgxSmjIaBBBcby//PqmdBITAg/y2lB27I4qcy5BU1lUPQDMfzMwXau+8 q+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=9azO1dZNqCpcvjOzPEkevlaB/dNEkdBBbt08o9p7OMQ=; b=0JVZTiPu8Jn5G+WZajAZVZY+CVIikDuLuDtf3KdFNrQvVaxx4SlwHpVLx11Sry+Nc+ yH6l4genoseGkRxj1UADMdyILOQitAzMKh77VpzJt0ZeVAyJWD0q/v2YEEYuj9SAUlUw vwoCNjH6itYsNxLztAYe7oafsZsAuniuqyY7ldiXADxzRFfgmzGv/ufHtACscB+uy870 RiIV/iJQpnkUkzgcIuj0doXHMCHS4/CodqE++fhZLeA+FWBWxSvv6ds5XUw7fKZVDrYX PszvJyUWnA7JulKLPLMaqZqlxO3IJ4GIE5EtmY1alpOHlUojjTF2veL8wkdS+K7YvtQd vgrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b="FaF/YWwk"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=umchNfya; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a25si489999eje.44.2020.09.01.04.50.08; Tue, 01 Sep 2020 04:50:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b="FaF/YWwk"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=umchNfya; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbgIALot (ORCPT + 99 others); Tue, 1 Sep 2020 07:44:49 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59123 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbgIALl4 (ORCPT ); Tue, 1 Sep 2020 07:41:56 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A5635E85; Tue, 1 Sep 2020 07:40:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 01 Sep 2020 07:40:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=9azO1dZNqCpcvjOzPEkevlaB/dN EkdBBbt08o9p7OMQ=; b=FaF/YWwkEtJgACjyc2uHponLFGWFEGR3ROixkHhvnb6 Xssz8kcZxNs5cGu7UuvuY0s8NI0eAiPcwHb8XRZOuQ7i+TbS0Um7LeMq3hSPg6E1 TVSl26AnyIjWe/7rc4VJLb+Y2ApN7lgqaK+UStkyBpRYht5fsHdgZjqjZ2Qyvwlf SYP2Zf27I1T5I/d41Zp7aDuRLqpUJ3+9VsWKKI93W+8XtpLmO6LCWQKudxxzATCW OC1yiMT5AdbY3/piMfT/7XNLQPEPLr/uA7BI2Tc3OLlLrUd/EjYFRj99HcbuLNlO TwNfHyhX9x48Cu5kFpy8xKthjWwFMEgFxq8efBQD4Rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=9azO1d ZNqCpcvjOzPEkevlaB/dNEkdBBbt08o9p7OMQ=; b=umchNfyaf/QvFjAE9hF9XK 2P5nENuThzppKBSmtEaBKLazC/MrALvwJtUBjMWuSVqVAKnt5whSuzLVqopP8CiU bamRAkyhv8sLpdk4kZX4rNUY/8M4b/vqSkHoi8hS9sTquhb1zez9tTX0+nrfDcI6 J2GNLYI0UeDjs34c3Uk+nT7ugNUfpRRj+/s2rWBHprMVNcgtwbssNVEeFWEt4a0V TPbaox9nZQ+cRQ/bcw41Bqdqa0JTGZs2188Bi0EMBqKtF+BkynHYs3cJqwldTS78 yle2qCrcUDpqlsO22pq8VnF+WtGr2Qe0QJ+o6snsREEcTBh2UvPZmOYd0FE0U6Ww == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefjedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A4631328005D; Tue, 1 Sep 2020 07:40:17 -0400 (EDT) Date: Tue, 1 Sep 2020 13:40:15 +0200 From: Maxime Ripard To: Corentin Labbe Cc: Martin Cerveny , Chen-Yu Tsai , "David S. Miller" , devicetree@vger.kernel.org, Herbert Xu , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: add new compatible for V3s Message-ID: <20200901114015.qivovvjqvmhkicdl@gilmour.lan> References: <20200831073101.3608-1-m.cerveny@computer.org> <20200831073101.3608-2-m.cerveny@computer.org> <20200901093249.orwyc5sr3z2y43fz@gilmour.lan> <20200901105719.GA2639@Red> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d4zgxzgmrbrrtklg" Content-Disposition: inline In-Reply-To: <20200901105719.GA2639@Red> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --d4zgxzgmrbrrtklg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 01, 2020 at 12:57:19PM +0200, Corentin Labbe wrote: > On Tue, Sep 01, 2020 at 11:32:49AM +0200, Maxime Ripard wrote: > > On Mon, Aug 31, 2020 at 09:30:59AM +0200, Martin Cerveny wrote: > > > Like A33 "sun4i-ss" has a difference, it give SHA1 digest > > > directly in BE. So add new compatible. > > >=20 > > > Tested-by: Martin Cerveny > >=20 > > The Tested-by tag is for the other developpers. You're very much > > expected to have tested your patch before contributing it. > >=20 > > > Signed-off-by: Martin Cerveny > > > --- > > > .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 5 +++= +- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i= -a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i= -a10-crypto.yaml > > > index fc823572b..180efd13a 100644 > > > --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-cr= ypto.yaml > > > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-cr= ypto.yaml > > > @@ -25,6 +25,7 @@ properties: > > > - const: allwinner,sun4i-a10-crypto > > > - items: > > > - const: allwinner,sun8i-a33-crypto > > > + - const: allwinner,sun8i-v3s-crypto > >=20 > > If it's compatible with the A33, why do we need to introduce a new comp= atible? > >=20 > > > =20 > > > reg: > > > maxItems: 1 > > > @@ -59,7 +60,9 @@ if: > > > properties: > > > compatible: > > > contains: > > > - const: allwinner,sun6i-a31-crypto > > > + oneOf: > > > + - const: allwinner,sun6i-a31-crypto > > > + - const: allwinner,sun8i-v3s-crypto > >=20 > > I guess the A33 compatible should be on that list as well? >=20 > This is the list of "need reset". > So we cannot use allwinner,sun8i-a33-crypto > Probably this explanation should be in the commit message. But the A33 has a reset in the DTSI Maxime --d4zgxzgmrbrrtklg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX04zHwAKCRDj7w1vZxhR xXtfAQCBNwO0KHktfVHdqJ1A31xqeae+JkhAoO14ISBQKDyKbgEAhtvQBryHrXgM Ts2NqtdzP/w7zF4ZtCJvTt3J9AKJmAo= =cE+X -----END PGP SIGNATURE----- --d4zgxzgmrbrrtklg--