Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] crypto: caam - use traditional error check pattern
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        linux-crypto@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Andrey Smirnov <andrew.smirnov@gmail.com>
References: <20200831075832.3827-1-andriy.shevchenko@linux.intel.com>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
Message-ID: <2306619d-66e4-6f37-8e16-6d97075081ed@nxp.com>
Date:   Tue, 1 Sep 2020 18:05:27 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <20200831075832.3827-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.13] (86.127.128.228) by AM0PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:208:14::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.20 via Frontend Transport; Tue, 1 Sep 2020 15:05:30 +0000
X-Originating-IP: [86.127.128.228]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 1dbe261c-9693-41ea-f4a7-08d84e887814
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2688:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0401MB26881A6BD0ECDDE24095C1BC8C2E0@VI1PR0401MB2688.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:238;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: oTcTPGGGbdFKT/iDbKM0eEq2FgDOkRq7mVb9Todfwo9gpfTOlAJeeXcQBALwQDLxlv1vuyXJ7/4SgVHvdAQuOj6l7XQwSNNDR4qlWb2ixT1d/lemZOuWiXCL4R6vncQgMhcLUgqDGfjYLbMsJLAi3V6fpnAJN3zPbdcUaPYwbGMekubux5EbDTh2sqAspyMsKySKGMP4s8//vspAPljPOgzGnD7uZwBGyfq6zmT5jCiUUZnXgnlII0jSSexxHWwjDO8l8gO5mDR+lKMXzz/N8wYJPFBmjXhe7XFBn0oL7Dv3lUPiWprvKYGTDP++vxVLADTYDVkY58A1uURrouALuUieILiKh+77HBuFXIpXvLcBdbQGA0qcqgTeaZ6viUD/
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3712.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(26005)(316002)(66556008)(2906002)(110136005)(36756003)(6666004)(53546011)(478600001)(6486002)(186003)(956004)(8676002)(16526019)(86362001)(31696002)(66946007)(5660300002)(2616005)(66476007)(52116002)(8936002)(4744005)(31686004)(44832011)(16576012)(83380400001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: osjaPi2eBYTmwY0OsLbGkdAqtUINZ6e+AqkJQREDTw47/pky5r7T6NPE82RQGuc6tReRQIvamf9Hq0UstefZoflEiYfAeQrOjlaK0nN9qoqHU5RUH13dL9ji1ux82pkmPznowjHo/dB68CxgmMAkbKfxO1JCG9E2F5BKxlM9GJA+dQuJ/9icr3p6SuNm+UCXA5o8w8Z+ApLzkB1OjZ/u0ZA3KS6es7/Di/+JnyZBQMjyFZ8ZGEPgFYGqwF6JfxyQwMWL+nPEpmlKf79QrkgBjr67ZcJ7GT/ZTZdoHy/BlcoGXrn7his40ti7TlzSNOekP5mEtbI4pR5z9U6TvUOPApWlUaKzCpg+YGj4QuUeX3+foVdZtwuLTtxak/U3fn+26oKEb09vr6gvKlnOgVVocTYV00ArJYpbR1sDPrrPqdYNbXGJfeYt1rb14zf9Lb4SLNcNeV0B9IJxW8x9wCY8YnByBhji1eTKt3NvonQ3JNze8HHyNwNMFbOdLqEg1xkzWWP4GL3/gVudpmSZvOYddcnsq3D+NjhIdgz2iG5VsLddPmmWmoH8fSlrtU3IkQ63UICgrTINOSMcxbihQjujOuZmrQ6N3u/BPJDdzI3OuSIPIFmmrYLUMh0cDFCql1mgKT6kvRG47iwWKWunFIPA5Q==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dbe261c-9693-41ea-f4a7-08d84e887814
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3712.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2020 15:05:31.2551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F3lz41E5oO99kYgQVwHVrMvk+dhXjg37jJu3tvmoTl0qMqreEB3s2VuqP52lZ5LcNi9rayzINlF/s0/GbLaFZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2688
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 8/31/2020 10:58 AM, Andy Shevchenko wrote:
> Use traditional error check pattern
> 	ret = ...;
> 	if (ret)
> 		return ret;
> 	...
> instead of checking error code to be 0.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

> ---
>   drivers/crypto/caam/ctrl.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 65de57f169d9..25785404a58e 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask,
>   
>   	kfree(desc);
>   
> -	if (!ret)
> -		ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
> -					       ctrldev);
> +	if (ret)
> +		return ret;
>   
> -	return ret;
> +	return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev);
>   }
>   
>   /*
>