Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Sep 2020 15:24:34 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     davem@davemloft.net, herbert@gondor.apana.org.au,
        robh+dt@kernel.org, robh@kernel.org, wens@csie.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com, m.cerveny@computer.org
Subject: Re: [PATCH] dt-bindings: crypto: Specify that
 allwinner,sun8i-a33-crypto needs reset
Message-ID: <20200902132434.qpevlbyx5wgq4daj@gilmour.lan>
References: <20200902091716.22650-1-clabbe.montjoie@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="lesihmyf7bejvih5"
Content-Disposition: inline
In-Reply-To: <20200902091716.22650-1-clabbe.montjoie@gmail.com>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk


--lesihmyf7bejvih5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 02, 2020 at 11:17:16AM +0200, Corentin Labbe wrote:
> When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs res=
et.
> Furthermore, there are no need to use items to list only one compatible
> in compatible list.
>=20
> Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml        | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10=
-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10=
-crypto.yaml
> index fc823572bcff..1075f0e75368 100644
> --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto=
=2Eyaml
> +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto=
=2Eyaml
> @@ -23,8 +23,7 @@ properties:
>        - items:
>            - const: allwinner,sun7i-a20-crypto
>            - const: allwinner,sun4i-a10-crypto
> -      - items:
> -          - const: allwinner,sun8i-a33-crypto
> +      - const: allwinner,sun8i-a33-crypto
> =20
>    reg:
>      maxItems: 1
> @@ -59,7 +58,9 @@ if:
>    properties:
>      compatible:
>        contains:
> -        const: allwinner,sun6i-a31-crypto
> +        oneOf:
> +          - const: allwinner,sun6i-a31-crypto
> +          - const: allwinner,sun8i-a33-crypto

Even though it works, an enum would be best here

Maxime

--lesihmyf7bejvih5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX0+dEgAKCRDj7w1vZxhR
xU0kAQCaTwLCXsqCEwANF758p9F7IT1H11DgVKytNwdpoVbCNAEA27d6vz1r1Ke6
6V2UM0Ao1xcmpQ3fTSAvvAv2VQJagwg=
=30nP
-----END PGP SIGNATURE-----

--lesihmyf7bejvih5--