Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp368708pxk; Thu, 3 Sep 2020 01:38:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCWZn/JtSoqjaoQ32CRvAr+nKOynWd5p+mtMdFoMnEuYmVNVfYVPaX77C5nxsjg8oLC1BE X-Received: by 2002:a50:ab13:: with SMTP id s19mr1834138edc.357.1599122313739; Thu, 03 Sep 2020 01:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599122313; cv=none; d=google.com; s=arc-20160816; b=R+7xLukgXx1s4n//V8tw+kkUG8Xd8sQ2FAacOcws+B6vixIin0FrgihYs3VVFsZltE indLGpBZubJJlnjSCFnRiMP44/fZ1MLWcGZ+mKSqpBujgXBp/u0F9TgqBgGvRXdZ0r5S 0so8Ior+doin1Koen3JUTcqbd3bns4OHYAZXeiPD9Fdq8o5+N4XAwA/yBMGE3OYCNUfK CkyOmuYhMyu1bGlKWmuNxLWljpF04hCowB5UE7UE8jnJUNVwBXShRtBd+8GXENqUT22q PfOkyfVQhcPkCekTCF1GWDkTKCEX5rWZ6QzGMJw/PIYjHyu/cdc6QbU1tkQDhiqA9KsT eOxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=nD7y009Bdp9QyT1ALyJ9VWsilMT9zbdJEO8dDZ1gYGA=; b=h716CZdwidYRni0X8boZxXqHls5seqj7vc1qFiD4AvtCoumR7kyrHBGcQ9JV9pesfD JG3oj2//UMj1HAZcAYl4LNcqaX/Ri/ks7u17BHuFiKg00Q9nFHkeHXFUU2L2W3VlQVJs 2cYj7zgYGQ6wdJqrVYDDVe1/LBtqUlimckIhPU4MJeNuLcYd/qWMYI4cCqQHr427Epzv lGSMSAXE9IodNbe3Fj1HD8fPIf5WvU6YAU1UplW6OmNqucGx0NfDPSqIsqNQ4S9LzLsh 181Jp3H0lzDl/A7vkKaqIMQMQx9is008QaEPR51XzY7FNi7di0hDEKgC9nu2ddp68nTW Hnuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si1439040ejy.124.2020.09.03.01.37.56; Thu, 03 Sep 2020 01:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbgICIhz (ORCPT + 99 others); Thu, 3 Sep 2020 04:37:55 -0400 Received: from smtp25.cstnet.cn ([159.226.251.25]:56116 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726025AbgICIhz (ORCPT ); Thu, 3 Sep 2020 04:37:55 -0400 Received: from localhost.localdomain (unknown [159.226.5.100]) by APP-05 (Coremail) with SMTP id zQCowAAH6SFUq1Bfy6kMAQ--.29402S2; Thu, 03 Sep 2020 16:37:40 +0800 (CST) From: Xu Wang To: krzk@kernel.org, vz@mleia.com, k.konieczny@samsung.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: s5p-sss: remove redundant null check Date: Thu, 3 Sep 2020 08:37:38 +0000 Message-Id: <20200903083738.85345-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: zQCowAAH6SFUq1Bfy6kMAQ--.29402S2 X-Coremail-Antispam: 1UD129KBjvdXoW7JF4UZF47GFy5XFW7Ar4kXrb_yoWDCFb_uF 1UWFZFgan8uwsayw45Kr17ArWDuF90vFWqgry0yF4rKFyUXrW3u392vw43u39rWa18A3Zx Aw1DWFW8A3Z2vjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb2kYjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lc2xSY4AK67AK6r43MxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42 IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8RRRtUUUUU== X-Originating-IP: [159.226.5.100] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCgUIA1z4i+SzXQAAsh Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Because clk_disable_unprepare already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Signed-off-by: Xu Wang --- drivers/crypto/s5p-sss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 341433fbcc4a..fdcbfd45c884 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2307,8 +2307,7 @@ static int s5p_aes_probe(struct platform_device *pdev) tasklet_kill(&pdata->tasklet); err_irq: - if (pdata->pclk) - clk_disable_unprepare(pdata->pclk); + clk_disable_unprepare(pdata->pclk); err_clk: clk_disable_unprepare(pdata->clk); @@ -2338,8 +2337,7 @@ static int s5p_aes_remove(struct platform_device *pdev) pdata->use_hash = false; } - if (pdata->pclk) - clk_disable_unprepare(pdata->pclk); + clk_disable_unprepare(pdata->pclk); clk_disable_unprepare(pdata->clk); s5p_dev = NULL; -- 2.17.1