Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] crypto: caam - Fix kerneldoc
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Chen Zhou <chenzhou10@huawei.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
References: <20200902150530.14640-1-krzk@kernel.org>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
Message-ID: <a273f81f-cdf9-70ae-3691-816fa24be0a9@nxp.com>
Date:   Thu, 3 Sep 2020 15:08:48 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <20200902150530.14640-1-krzk@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.13] (86.127.128.228) by AM0PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:208:ac::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.9 via Frontend Transport; Thu, 3 Sep 2020 12:08:50 +0000
X-Originating-IP: [86.127.128.228]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 9f76def2-573b-4a5d-dfef-08d850021f8c
X-MS-TrafficTypeDiagnostic: VI1PR04MB6944:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB6944A45A128722D6911D03AF8C2C0@VI1PR04MB6944.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Rd3vyxIL1zvlOWNKijG+iTQLuicmJlPuvLkxY1Y4n+IU4zlK9XrnZ7hY8yOAOblHgJPRa4UwXSjn/PH3DpMr5DlqudZYa/zuBF+TR17pQU2vdvz0Cnq6oRITyzMxFTFmzBCWn3jTvFw52ybMN0Ap+lpA8dSX6ezBiAoiyozbV0cU8xd4XF9nKay2ylrggNP0wRJ3K+EoRB5DuMoLY4lOg21IDdva+1V9556P2K9NEoh7xqo5baqJDpj9t5GQ2T0RhgiyrF1HpSt0fR5F/Q15kFxIXIp58ozOppiyzy9Evoq6s6G432K1vfodt7hrv9BBShx4XFjXpG+/H6l92Qz+5UDB9gglKiz+71D5iDw8hcQ41TGfV04s7Qy0HQowHGSLH1c2xe+ZV+1J5rSjFjE+9A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3712.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(478600001)(36756003)(2616005)(6486002)(31686004)(86362001)(110136005)(16576012)(316002)(31696002)(83380400001)(52116002)(956004)(7416002)(2906002)(16526019)(186003)(66946007)(53546011)(26005)(5660300002)(8936002)(66556008)(8676002)(66476007)(44832011)(921003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: Srti5ts1LX46sV+V9GrfO6Veegg5VVH4VrOKFqH2AKhLDfI1Dj1a4W43nbf8AD3u8gGbMowP5j1AcsGsJI97Lnk9oGaDdrGA8uyTUFvjIG7Da0ypspwA8TSmND92lxYZfHLGYX5gDddZ8KmV75E5xLFAAw2M1BoC8s88rKJgPXC8XhsgT+AwX+m0jEz7gFPmgAaSOt56VKrPonyzIkPnhdMmoqdqBxGZjTr8P4P0Hxp0BjHuQTquC9UjKANK9+eVAO7vtUUUI/A3um3+m+RqAdSjHbPl8QmNS1eeOyxhrTVn0icMEX47jzTjn7EGC7b3Y8ayOEd8Rb1/lH8ndKmFNM5Wl9u3Kk95RmRn3oNm7mlju2gHCiErLBtRSYBTlHpaQs6afLw7/i7pRm0YKUM9z28xG1Y+rNagAMnOCRoBhJ1MN5jW6nhNll6z17VT+Yh2Frq5ohtAYlcmoD2nCEYbN7xNavWj1bbbIPO/Utek5KMnIub/1qjyXkvNsZRxCVIQ/F6B5QEwkAtILO7DWZmUEPd+fHAZv3g9EbFybOHMkU/ykM+vM6ni+iC7DghjsoYpTHnNANrhZo9yRKGmjHmfBon+olc1t0kYC1O/kAzpO0sBdah6iyW+zo3kIwhCy1E5wmulJDzNqyl9aXJuvMueTA==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f76def2-573b-4a5d-dfef-08d850021f8c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3712.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2020 12:08:52.6125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82FeqdZUHVfB3Nuw0T+owvSmEFkckEYEk7Va2HTxkCwnivy7HBVzdfnEGVhi9ZXLQHqKlll9PSAGNgn76MKaeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote:
> Fix kerneldoc warnings:
> 
>    drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function prototype: 'struct caam_ctx '
>    drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function prototype: 'struct caam_hash_ctx '
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
This LGTM, but, while here, can you, please, check the other kernel-doc 
warnings:
drivers/crypto/caam/ctrl.c:449: warning: Function parameter or member 
'ctrl' not described in 'caam_get_era'
drivers/crypto/caam/jr.c:331: warning: Function parameter or member 
'rdev' not described in 'caam_jr_free'
drivers/crypto/caam/jr.c:369: warning: Excess function parameter 
'status' description in 'caam_jr_enqueue'
drivers/crypto/caam/caamalg_desc.c:387: warning: Function parameter or 
member 'geniv' not described in 'cnstr_shdsc_aead_decap'

Thanks,
Iulia

>   drivers/crypto/caam/caamalg_qi2.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
> index 66ae1d581168..0441e4ff2df2 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -59,7 +59,7 @@ struct caam_skcipher_alg {
>   };
>   
>   /**
> - * caam_ctx - per-session context
> + * struct caam_ctx - per-session context
>    * @flc: Flow Contexts array
>    * @key:  [authentication key], encryption key
>    * @flc_dma: I/O virtual addresses of the Flow Contexts
> @@ -2951,7 +2951,7 @@ enum hash_optype {
>   };
>   
>   /**
> - * caam_hash_ctx - ahash per-session context
> + * struct caam_hash_ctx - ahash per-session context
>    * @flc: Flow Contexts array
>    * @key: authentication key
>    * @flc_dma: I/O virtual addresses of the Flow Contexts
>