Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1142742pxk; Fri, 4 Sep 2020 01:28:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaK1jJ06yxu4Bae6b4t61Lbz7TG4qDNfl5m8YUjlWSxm4Cg56C4FwDnqc+jYz8mC+/8rWm X-Received: by 2002:a17:906:ae45:: with SMTP id lf5mr5991023ejb.339.1599208124503; Fri, 04 Sep 2020 01:28:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599208124; cv=none; d=google.com; s=arc-20160816; b=xSRf25Nz04hLEis5TmUoo9ain3COInMhyk/yiGNQuxvo6s6QwT9qZS3VJXLTZYMHUL Jpz9wAWyXxnoptyy+lwMAW+nFpFPyMMS5GvkOBoivRwS/k46/An88kfVMVsMyH2BNgqf KRmNhEnotU0Za4yoP+Jq4jWiqqLmymBj96jOwi6xOwK5htAH5QkWB/8rvsuW/UDt7rQr TYA5k+c4ljujHt4MpDzxPgP3oyWQ8Ko80ceusJLs7ym9MG/8+IfR0+eohbF+W8/QkL6u EFan0HH3UF4YKZ5y3SojfxYUq5312UwqaN8gshpli4M5mS3uRj9mE3y+U9j29Y9kjT1s ySKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=99Ox+MINl7zVa9SOOroHgOw+fDCPBBkZRXmSsvAYwh8=; b=R0B4XwMOvpLWwnsEsCMbc+KDz/giri5PzcTUa5YJWJ8V05IJqAhMnHctoejnj3ILFk yN/IpVHjgGld/ocrphPmaxzvP906lJkmpjRgk2KZ2Kav6U+Mq3/8LHeN0zI+2FvoivoW 5bJ/BGJbN4lmPQUDlpMF/zWybFogByJKduFt+R7tNaQt+ShDYC9HNn8elFWDMvJhknwF JQAemMcXWtyGse8TpIAFJ/WzXUtMvVt5LGcSpNA6cdy0vQIS3ELlnodvcYPmcSl6JG9u NDlzOBvmVxuGp00GIn2eduu19eTl2pBZgqj/qH5DBjych9yDySXhRGa+8gWzM3ilJPMc 396g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si3656219ejr.342.2020.09.04.01.28.16; Fri, 04 Sep 2020 01:28:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729582AbgIDI2N (ORCPT + 99 others); Fri, 4 Sep 2020 04:28:13 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42676 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729572AbgIDI2N (ORCPT ); Fri, 4 Sep 2020 04:28:13 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kE74d-0001Op-Rl; Fri, 04 Sep 2020 18:27:56 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Sep 2020 18:27:55 +1000 Date: Fri, 4 Sep 2020 18:27:55 +1000 From: Herbert Xu To: Krzysztof Kozlowski Cc: Hadar Gat , Matt Mackall , Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: cctrn - Simplify with dev_err_probe() Message-ID: <20200904082755.GA1214@gondor.apana.org.au> References: <20200826153233.27586-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826153233.27586-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Aug 26, 2020 at 05:32:33PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/char/hw_random/cctrng.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt