Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4257882pxk; Tue, 8 Sep 2020 15:11:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyWhAxZa01UJCfXEVdH6XQprnFnoVWS/b16yeJPau3+GCbvrysAz46Z26hpwTDegK1z7HC X-Received: by 2002:aa7:d747:: with SMTP id a7mr1159075eds.304.1599603102514; Tue, 08 Sep 2020 15:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599603102; cv=none; d=google.com; s=arc-20160816; b=EYxl4om8TXJ+/60Vtqid1P8nFYvZ7XZSLOANsy6+CgYS44+i/p7mm/smnfg+8h0E2N 6b7jcw8U7d1dhWYiiGTNC9NwWZILurG3pffgarBJ739uykQaQWob9PYd8n70V3/ITmee mhP0k9SGLkKLaRsWno7jPh9M0LVlU2eoqe8W6O3Bi2tA5SvgNWKzAvefsFzsnPZ9GkiG dOqhP1ZY/XzPCtAbGlTpawOqTSztNGugGf7Qi19rlBYu4B9DlCNNnm0DnqIgvTL2oq4C JPLYMdTIhjpm/wdf+/D3PJQ3ZPvLO0+Bp4Pb9R/jof61IfaHKbsL/BOquCvy6vEjPssM Y5dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=VR4oB61MlnuTpXDnmrRAHjRoTZQW6qc4et0xzby+81w=; b=fQe+eh0TIS1YSIT2r36aZ00ftuKeqIB+mGZl9krW4znKA5JZ/EEyvTxDfqf+1+87wu mPxKpY83tR/Ls1Qnm7gwAFcJZkyIo2AsYbxGeXiLKuyvmf11bbud51fbARy6S1SRfnbw wT9nUJW/6Ay4sSC5V3toVE5AFaFHR0sa9PG/3mh+8Dkz5YdoHKHjBv5WILJh2uzNWR7N PvXxZ61dSzNcZpiMXN8P0GSz3DlykpdZh6N88vfEaQpALnUCkYNb5fxIQxg4bWFpPQZ4 cQyXjsc+69kalE5MLM+bhvdLMazll7GuOQ7ZNrsfEIDgnKzWoV0WBYvhOc7r7G+PRWT7 s1hQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co12si303529edb.104.2020.09.08.15.11.05; Tue, 08 Sep 2020 15:11:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729785AbgIHWKb (ORCPT + 99 others); Tue, 8 Sep 2020 18:10:31 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:54512 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729655AbgIHWKb (ORCPT ); Tue, 8 Sep 2020 18:10:31 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kFloh-0007w6-Mq; Wed, 09 Sep 2020 08:10:20 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 09 Sep 2020 08:10:19 +1000 Date: Wed, 9 Sep 2020 08:10:19 +1000 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: "Andrei Botila (OSS)" , Aymen Sghaier , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ard Biesheuvel Subject: Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV Message-ID: <20200908221019.GA23497@gondor.apana.org.au> References: <20200806163551.14395-1-andrei.botila@oss.nxp.com> <20200806163551.14395-2-andrei.botila@oss.nxp.com> <20200821034651.GA25442@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 08, 2020 at 01:35:04PM +0300, Horia Geantă wrote: > > > Just go with the get_unaligned unconditionally. > > Won't this lead to sub-optimal code for ARMv7 > in case the IV is aligned? If this should be optimised in ARMv7 then that should be done in get_unaligned itself and not open-coded. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt