Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp862818pxk; Wed, 9 Sep 2020 23:54:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw+47QMNrCeC3KwxRpk2lcCrTMcQTeV8ZiHSKcMQtzqdahJDz0StGoCqtVU8+LVJjjbXnZ X-Received: by 2002:a50:875c:: with SMTP id 28mr7782407edv.20.1599720843811; Wed, 09 Sep 2020 23:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599720843; cv=none; d=google.com; s=arc-20160816; b=cBpJssUmasOLu3V8XXafeb0QoHKvDA1oCEyW5pZ9g3CmmbdE1NuR4tC0LV8X3k5799 NYFkJ41bpOb4+oWpMCUzTtsJfpfPqqZglIG88GU6XqE0guT3+C/96SMe+PRcyMP6E5x9 nGLV5R4Kah0LK1zB98CWYIlcdqimKKwIfV2MCTMYm9P/mCjgx9L98Im239ax+F+I7bF3 gjoRS5PkFUFJM9ydLWEHGqYziP6AlLXRfrDR5qRlqPlKqDzhk7wnocFg270rYniFvDmo zP185/gAKtI0tMeBqzLELbAbLMoTAQSS4pgw3upBZ+MdYWYro8eyyeREWvFmhx3UYhoz Oo/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mrYigyytgWJrMuaHI150u+ukLTghQFIVrE+aFNtBt20=; b=tclPyrHhZcuQEeYOv5vUVQRF0ezS9IxCiXv2XQW0rLYZS4RG54jhCk9i9JoNKXUiLe pFfVitVsojQIqf38GZHD2QR/1rdACvU2FEIJh0yXProVl0Klpw3fohJe+L9Zhdl3Evsu 8O+yqIV2lftg+tFVnbxwI8cgwbkFlx6k63LkOlka4lOJiumbAAqUhvKGtTo2JJqB2hB1 d+FjhD7m2SosmtrjdVCAyb5letic2l32L/tYjOWeS03QgHznm+RnKFuCl993xu3EXKNY bjlDJ0TwFUwN/6RXEEdiVFHEOKHZTHJv+7hidOLwzLip/LCqVvXsXWobnVPIn6bUGtun pssQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e3Jk9M7Z; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx11si3330683edb.189.2020.09.09.23.53.31; Wed, 09 Sep 2020 23:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e3Jk9M7Z; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbgIJGxS (ORCPT + 99 others); Thu, 10 Sep 2020 02:53:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbgIJGxQ (ORCPT ); Thu, 10 Sep 2020 02:53:16 -0400 Received: from localhost (p5486ceec.dip0.t-ipconnect.de [84.134.206.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93A222078E; Thu, 10 Sep 2020 06:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599720795; bh=/LOePKGDUR83plqAhx1ySvpBeTmOBTt4AYD41Ar10p8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e3Jk9M7ZKtsnsBd892ykDqq6ldjJyX23IqJ7DyDWgKOR2vkDHWpTUx3L4W3ZSGRl8 gbJ25CK/q4T0DRgLEQdFDMLfOBf9AoSauHV2UkWklXje0SfXK1Ub2yM0Bl5ncgFE73 tRqSbJwVN+gRudxLpTtOTt3VxbQSMkA19oVYS08w= Date: Thu, 10 Sep 2020 08:53:12 +0200 From: Wolfram Sang To: Joe Perches Cc: LKML , Jiri Kosina , Kees Cook , Nick Desaulniers , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux-foundation.org, dm-devel@redhat.com, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, intel-wired-lan@lists.osuosl.org, oss-drivers@netronome.com, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-scsi@vger.kernel.org, storagedev@microchip.com, sparclinux@vger.kernel.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, bpf@vger.kernel.org, dccp@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-sctp@vger.kernel.org, alsa-devel Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Message-ID: <20200910065312.GH1031@ninjato> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OpLPJvDmhXTZE4Lg" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --OpLPJvDmhXTZE4Lg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > fallthrough; > case PCI_DEVICE_ID_INTEL_82801CA_3: > priv->features |= FEATURE_HOST_NOTIFY; > - fallthrough; > + break; > case PCI_DEVICE_ID_INTEL_82801BA_2: > case PCI_DEVICE_ID_INTEL_82801AB_3: > case PCI_DEVICE_ID_INTEL_82801AA_3: I am not the maintainer (Jean is) but I suggest to drop this hunk. The code is more complex with multiple 'fallthrough', so this change alone actually makes the code inconsistent. A rework would need a seperate patch. --OpLPJvDmhXTZE4Lg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9ZzVQACgkQFA3kzBSg KbYNuA//cymFe0KsFqywRHv3eBWJhoqwvWN2Xhwrx5/b6N3kkKGTo61aOo1ZI2gU 55rQoGusy8OzGXaxlyhNS8Ea9ztPZc/tHEohOHKPYr52ErUMXlbMo3I3q7sZAZEI O/bRlnPKUCKqKOpZBin0ri6NE3FNYybTW30HgIk/LFUeCuaup10cUcxCmPfXHlNc M/2M2tBVyyBOqlVVsPxIfEZ4jGDaikxt7mBZDj4QMJnivnuMFuuz8U7gYzkXIHfO 4ahGx+dBLCCInwFNFjEIPr+biq6Bgt/Vl9bbgN/BYbzdgbbJcikEhWHd9FxEoxQ5 Y4M6/HxLDuCwTLIoFHjVifsFHK4Emk5ECc0xBWjHu3CJDunZSmy6yS5gbD1BrstW Djf0Ue1kyqnVPBDKE0EwFmwz1z1V14bhhXVC1fkiJjTpYRA6g3zMwH1oan6XIbGj v4OuWFDkQLEfzCCBIASGS849HtQ4rNafKxX3KQ3qxngh7XBrK7X92SLf3qRJurdt h5Ozd/zYDzyKQ1nOf/XWAOP5SKZH2ANjTrFKgIZE8MRkTmbzrlZkCnDnFD0pKPlB Z9h9uPZ7kifAejwaRPfsTu6/B9XJafMKfLa3hKTg2kgO+p67ItBEQ0W8wrXLE1/1 c5FW5PqdkjKnx/9yUqosjEsHV2goh1guE4cziLkF1pZXcrElbtk= =ZP3J -----END PGP SIGNATURE----- --OpLPJvDmhXTZE4Lg--