Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp65159pxk; Thu, 10 Sep 2020 23:58:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK1H9xfqWlxZ/xC1ELGUFb5W7UMQDUAY8qf3xCOA/044Nw9+J2+RtmvnjODNOIuHvSW40M X-Received: by 2002:a17:906:8687:: with SMTP id g7mr683882ejx.129.1599807523642; Thu, 10 Sep 2020 23:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599807523; cv=none; d=google.com; s=arc-20160816; b=FHIpbCVQ0n4zFTT54+VUkq74a7CTry9Xo9BscEoN0Xud+jJMDNjBj5syfdEBgiiHad wuB3awTEtAQNTGsi5JcrTR0uIFd8YaXUORvjxiN6qLLJaJl5gG0bkNpLBJvUkDDyYkbb xPR9wY12vHl6q6rQN8VEDshi/g5L1kIs13ozMVYKkivL6xwjG7eyxBaUyTNnD5LMg0fw ccJXNA5IlolwQOLunBsjJXDDtiSJRk4awdwB47VYDOcSF8ua4TtyYX9nrnWrYx+FYCCa a+RBIMQfW4UD1lfQ+7RiUrrgbpBgryRzoXpkn+f8+4MK8H2K1d1fSUMHz+EWRp+eQdf0 r+1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=z6hc2yhkmR/oYUKK5wRTjIt7QeD7goj1XebihR6dIOw=; b=slwA7JTSTv5XqOLEa886jpW31OSimuw9bGF/I67XIkFq42hydk3azuYaSPfJuhFGBN gV1V+q4jTaHYxi1IRzuntoyoQSG50+7RrXw0kQUuT+IscmKOVuj1fHabraDMN1bnnb/s GJ71wH0QZvSY40OpStdnWeCRmscaQ/7kY0QUnJv4hShe6xxWVRSqyZALsJbr8BeKhiiu piLqyHN61nxRxQcOMmELhbmM7IBr3pCnNmsWD68gnh1ySECGDleyTPPzibCBsw1g0ygk LyNcaza4w9xwgZcvPwSwTHY+gbLlD3sTqa0QMvK1tbFjpU1mgANxneO9sJHcW7765eug TT9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si793946ejr.202.2020.09.10.23.58.19; Thu, 10 Sep 2020 23:58:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725770AbgIKG5k (ORCPT + 99 others); Fri, 11 Sep 2020 02:57:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58936 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgIKG5i (ORCPT ); Fri, 11 Sep 2020 02:57:38 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kGd00-0007tS-QS; Fri, 11 Sep 2020 16:57:34 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 11 Sep 2020 16:57:32 +1000 Date: Fri, 11 Sep 2020 16:57:32 +1000 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Dominik Przychodni Subject: Re: [PATCH v2] crypto: qat - check cipher length for aead AES-CBC-HMAC-SHA Message-ID: <20200911065732.GD32150@gondor.apana.org.au> References: <20200831105959.107261-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831105959.107261-1-giovanni.cabiddu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 31, 2020 at 11:59:59AM +0100, Giovanni Cabiddu wrote: > From: Dominik Przychodni > > Return -EINVAL for authenc(hmac(sha1),cbc(aes)), > authenc(hmac(sha256),cbc(aes)) and authenc(hmac(sha512),cbc(aes)) > if the cipher length is not multiple of the AES block. > This is to prevent an undefined device behaviour. > > Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface") > Signed-off-by: Dominik Przychodni > [giovanni.cabiddu@intel.com: reworded commit message] > Signed-off-by: Giovanni Cabiddu > --- > drivers/crypto/qat/qat_common/qat_algs.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt