Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp286024pxk; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPoHA3vPesemHsd3JRfPSjn15zHqAcYJ3KxG645DfqJ0pI0ZWORS7ZuAJ+6X86mKxS9oZf X-Received: by 2002:aa7:cb83:: with SMTP id r3mr31532249edt.35.1600337172479; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600337172; cv=none; d=google.com; s=arc-20160816; b=OhQC7L98r9PpClw+FJK93GYNYhgGHvC+kBsAPMh4MSZSCRWcWTDmOI9A6k+YKvEuiU ojQzuviDdrBFk4K2qq4PQozLxZ/MoPZZjHwrc3MKYHvuPys4Zu1wzCJV9paCda2jm69h aLnJ2TxK+nwQGkKyBnbIka379qz2E5unGJMsHIqV2zPr7W2SQKzpAOQoziCk7Xoxbmtv ezXRkB6UWGaBPYf2JMV3TMfQVVr6YfuyjExzWkutGenNCZJDa9LS2U+berYahrN3UdGr iw9xZtDGzcxsvYnLyUcCiF/woDWbKW3stpu8SUAULOoiU7iDccTA9+dJ/IpjVBjyWNfV 5atg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=etDu0solC5EHZ0a6cTnafdPGtZwvbpt/Q8uDwacTzb0=; b=nHjhLVZfelIsx0zhBEoAOrzYpqVVT+h76uVyNg0+1ZuDtlmygLIt415noOsqBnULPt 8lsXMpsSjYNTHwvHe2S51RhsKvJE8POPJRxE28fdV4PITOw+E0uJB2SPqm+Q1sSaEA/1 hlyh2/dfziho5Ecep+Y1XuzHFEFcY/MuLx5G3U64TmNGyyyCrysNcc7eo4fAKWZf91C4 0cRZQBTW5EFWp8N82AUDCcx/yp2IIQ/cmeYPIFcMXjX7lFZyNrUa+r5Dtjft2kNJtlVh +i4wEjSDtDiNtwpndG95KeNoTC3/vwkDoiBhheZDfOns0TkBLZvjCryiSOma8+lZpcAf AACw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="T6E1hto/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc12si12796097ejb.491.2020.09.17.03.05.39; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="T6E1hto/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgIQKFb (ORCPT + 99 others); Thu, 17 Sep 2020 06:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbgIQKFY (ORCPT ); Thu, 17 Sep 2020 06:05:24 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85913C06174A; Thu, 17 Sep 2020 03:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=etDu0solC5EHZ0a6cTnafdPGtZwvbpt/Q8uDwacTzb0=; b=T6E1hto/3ToiS8tEe7XA6ZOPy9 yaNF0YLLVxqLa0YJWuGC9geGUEt8Hy4qoH4Pp52NSuKJyxc9jtFzsMsCaP5q3u8w+Lgjq+NYS1pig uyOaqV36xtAolloyVQruPOXo+likgIAY9YgMNVRVuKech2GAFb0zBapdM+74nUPJJUKKpNqO0UfSS ZndZBx0Y/nPQG6s1N9rvUGUHnAJ13mbDBbWl7qu/X3ozlNMnm1qkI0m3Vz/BRt8n+gN2WzZzPhW0Q GP9v3fCEozhHXdvVXwV8b2HrAxL+BWnTpz4UE0ZwfxqLmHj8nGf85YleQo6QTcXR9dKJuUol8RLPI /Pb6boJw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIqmg-0007Lt-NG; Thu, 17 Sep 2020 10:04:58 +0000 Date: Thu, 17 Sep 2020 11:04:58 +0100 From: Christoph Hellwig To: Rik van Riel Cc: Nick Terrell , Christoph Hellwig , Chris Mason , Nick Terrell , Herbert Xu , "linux-crypto@vger.kernel.org" , Btrfs BTRFS , "squashfs-devel@lists.sourceforge.net" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Kernel Team , Petr Malat , Johannes Weiner , Niket Agarwal , Yann Collet Subject: Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API Message-ID: <20200917100458.GA28031@infradead.org> References: <20200916034307.2092020-1-nickrterrell@gmail.com> <20200916034307.2092020-7-nickrterrell@gmail.com> <20200916084958.GC31608@infradead.org> <20200916143046.GA13543@infradead.org> <1CAB33F1-95DB-4BC5-9023-35DD2E4E0C20@fb.com> <20200916144618.GB16392@infradead.org> <4D04D534-75BD-4B13-81B9-31B9687A6B64@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Sep 16, 2020 at 09:35:51PM -0400, Rik van Riel wrote: > > One possibility is to have a kernel wrapper on top of the zstd API to > > make it > > more ergonomic. I personally don???t really see the value in it, since > > it adds > > another layer of indirection between zstd and the caller, but it > > could be done. > > Zstd would not be the first part of the kernel to > come from somewhere else, and have wrappers when > it gets integrated into the kernel. There certainly > is precedence there. > > It would be interesting to know what Christoph's > preference is. Yes, I think kernel wrappers would be a pretty sensible step forward. That also avoid the need to do strange upgrades to a new version, and instead we can just change APIs on a as-needed basis.