Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp625110pxk; Thu, 17 Sep 2020 11:38:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGB8eL6i1GeZS0QSgDgsv33qBHhy+HQxscv96jgz4CayvcWCD5ufS6EfqrhCuEyE9NVkr/ X-Received: by 2002:aa7:c444:: with SMTP id n4mr34777771edr.200.1600367913222; Thu, 17 Sep 2020 11:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600367913; cv=none; d=google.com; s=arc-20160816; b=yE/kZT4LsPQaKvblkeikd3NAeMgRTR6zNyp47fksmrWOORf/8R0vCSIN6Ez/ngYHDt qS2uordzKpf1evLh9gjyn1egHRyVL0fNAe62/jLpH+1uZ4LIB89YjS+9h8rVl2yAWAKL FEYJWPOZPvhHxc0qRbU9BN3GoJqZYny3AICTdbUjybL8DLmN7S2YM8jPI510KY+vGZdW 0C2ozZdCXhgw2gCWd+Q9NAowbrj67pj8iTq66gGx5WVFB2pT1dWWwkao0ty6mA3C68ZM JkH4cHnN1ni6ZxfUYw6M+uilo+VXW5VxmjgcFFC2V/WToMVHcODRpYDdqsnZHShD5eTm MoAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=95zSQXucA3JVtCyytHmj0YY6t7Txi03VIMdUw17K6OY=; b=OZPlMgLSUqY86VqsKz6e4o8I4prbma+0P/nah5xEEJFgh7ibtD2vlpdtXQQIlDGNim a8i63a/aacARUXwgq54xTnJRzwtn4BqUnnPGL8+3eyDNzgs7qu2VRfD8F41fpGTPTdth 6tS8+vU2YTN4e5VSB8iv6pRS0FgiI/9udH/uD2PIktJ5IliMAh2IvN+963WpRk3lZv8U yvJ4bSNqcURQF2u+X3/XLPpnWFxRMLLAq1I1WIVNgvf+PJngfS5hIeibsPFAoj8ia5Gv RCwkFo92jd88YpHZm0vRdATvUvCFDE2o4DJOCqZad6WIiW2pb1Bfs6hnfkSjjYPQcL64 pnNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=dy8qrGfB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si341915edu.609.2020.09.17.11.38.09; Thu, 17 Sep 2020 11:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=dy8qrGfB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbgIQSgr (ORCPT + 99 others); Thu, 17 Sep 2020 14:36:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726649AbgIQSgO (ORCPT ); Thu, 17 Sep 2020 14:36:14 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24731C061355 for ; Thu, 17 Sep 2020 11:36:14 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id k15so3105520wrn.10 for ; Thu, 17 Sep 2020 11:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=95zSQXucA3JVtCyytHmj0YY6t7Txi03VIMdUw17K6OY=; b=dy8qrGfBrIm415C/AKe+zhxMSYXEPCm5p9tVIbpQLxrIuNdaArcxZmfXZ2+/RjNVSr cePOmHKnEe8/oekKxsYVXhS0ri5fv0JFc85DA/dP2bKxJfQfndLjhVb+x/+zOD/HXyMn rj45ayusWqqcbZXaaPYBr297PIQka5gcTb11rNycGtej9/l27rxbt4x+xnzUFOmN+/6d QBYEM6og75J3XUgMb306Mumrb7sSofApnV8jTGgGvhykwNDPRHl3XBZwxQ9j+n/b/U/i rkWlL9qDydk04KgRl65sEpqnbosBla5cYMC5Mom2JtamY9zp/HfqYT1X2z+PJDfr6d5F Umlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=95zSQXucA3JVtCyytHmj0YY6t7Txi03VIMdUw17K6OY=; b=tGaAWjIKuZzNyHB1karo6xJnkoBbRDO1hoKC90AyNDwgg7fb9ge4t0ceoXcyG/VXMA LuspfDIfSNM7xOOC5LP2KNdiuWKU9G5k10exB8inuB7Ig3xyZLjZvqeLJ6zieMDiL2Sk AmhlTcPw6mUSbfrSA/4UV27vdvZnjVdUP+YsdoITbAUW/z8oO0FyMcZEg1T95bEtCShq tBP5t2iGOQU0fTDLM644+Ppmgdrc41SZdn8wO6gF8aQEHLj7wJyQSkRCgulfJ9ZK2HOT hxMTXs/+jUhjWRO+q2tmr4wi3RKHHVS0w5pUBZ656sX6UcdcarNloWRmvQ6CQi6Woicx IpzQ== X-Gm-Message-State: AOAM530lMcsw3CcPwF6lTEgzYCbYmiSjE+HU9CNkDoULel6XnppgkpSo bHGnarECxm0OLYXFvdJr4lYrGA== X-Received: by 2002:a5d:5261:: with SMTP id l1mr33249298wrc.193.1600367772844; Thu, 17 Sep 2020 11:36:12 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id x16sm571901wrq.62.2020.09.17.11.36.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2020 11:36:12 -0700 (PDT) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , stable@vger.kernel.org Subject: [PATCH 5/7] crypto: sun4i-ss: initialize need_fallback Date: Thu, 17 Sep 2020 18:35:56 +0000 Message-Id: <1600367758-28589-6-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1600367758-28589-1-git-send-email-clabbe@baylibre.com> References: <1600367758-28589-1-git-send-email-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The need_fallback is never initialized and seem to be always true at runtime. So all hardware operations are always bypassed. Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index d66bb9cf657c..c21a1a0a8b16 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -181,7 +181,7 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) unsigned int obo = 0; /* offset in bufo*/ unsigned int obl = 0; /* length of data in bufo */ unsigned long flags; - bool need_fallback; + bool need_fallback = false; if (!areq->cryptlen) return 0; -- 2.26.2