Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Sep 2020 17:30:25 +1000
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org, ebiggers@kernel.org
Subject: Re: [PATCH] crypto: mark unused ciphers as obsolete
Message-ID: <20200918073025.GJ23319@gondor.apana.org.au>
References: <20200911141103.14832-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200911141103.14832-1-ardb@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Sep 11, 2020 at 05:11:03PM +0300, Ard Biesheuvel wrote:
> We have a few interesting pieces in our cipher museum, which are never
> used internally, and were only ever provided as generic C implementations.
> 
> Unfortunately, we cannot simply remove this code, as we cannot be sure
> that it is not being used via the AF_ALG socket API, however unlikely.
> 
> So let's mark the Anubis, Khazad, SEED and TEA algorithms as obsolete,
> which means they can only be enabled in the build if the socket API is
> enabled in the first place.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Hopefully, I will be able to convince the distro kernel maintainers to
> disable CRYPTO_USER_API_ENABLE_OBSOLETE in their v5.10+ builds once the
> iwd changes for arc4 make it downstream (Debian already has an updated
> version in its unstable distro). With the joint coverage of their QA,
> we should be able to confirm that these algos are never used, and
> actually remove them altogether.
> 
>  crypto/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt