Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Sep 2020 07:59:42 -0500
From:   John Allen <john.allen@amd.com>
To:     Pavel Machek <pavel@denx.de>
Cc:     thomas.lendacky@amd.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp - fix error handling
Message-ID: <20200922125942.GA8119@mojo>
References: <20200921113435.GA20450@duo.ucw.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200921113435.GA20450@duo.ucw.cz>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mojo (165.204.77.1) by DM5PR19CA0015.namprd19.prod.outlook.com (2603:10b6:3:151::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 12:59:47 +0000
X-Originating-IP: [165.204.77.1]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: e9e3ca4a-f3a6-49fe-ba92-08d85ef762dd
X-MS-TrafficTypeDiagnostic: SN1PR12MB2557:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN1PR12MB255707BA438E9B801BF0954D9A3B0@SN1PR12MB2557.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 4YbVEpnwxyeU1eoI2QU1T7yLmA4ZtVMfeIQezlB7ZcSkr6BYjhMtSzpJSsmhqFnGdyqXjRO+Hjkn5Wcsgdfc+LqSCJ68mDz9zOxHnH0zgHMl61TrdA2ooEdh+tcGN334g8J22TAO1cw8HZ5w5obK4wl6PC3ciIDHpvqbmV/PPyQOdwqfHPHxmBA6BXc722jj27Wy0Ki3xWA/EY1zHf1yCAcvG9dnIfSTV2TeRD6FfxXaXXA1YUqvDHa6I7KJzRPS9c9U3X0n0eIGRQBkzakulnNDYSH6+hUfV5s/ZvOp+8MEPRkq+hQCEAQcka0Tg4x6g/H90QBqY8jCthDVzrIoeQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR12MB2590.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(366004)(376002)(346002)(52116002)(16526019)(8936002)(44832011)(2906002)(9576002)(66946007)(5660300002)(4744005)(6496006)(66476007)(66556008)(1076003)(6916009)(8676002)(33716001)(4326008)(86362001)(956004)(316002)(55016002)(6666004)(33656002)(26005)(186003)(478600001)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: Y61SzCxazvaqJPkltYan+52Bg8a4CvSwiGWBSrgsYZdib+r/jP8RnRntCq5dRU3jnfE8quHoY8HVdsC+ePX+biFzu+DTpIbjDnLQXi5gIR+D6okmiGre7XaEahm+uMjYN1nhFeHkDU7zLUe8jm+o1XvOY7ba8ol2Do49/z/0MPwXDP6bYW9VPMybQiTCqGi1VJL8W5uBVxfbJ2++I/7NJ+FJBNbwLQe0CrSrZKSe7T0WVWSTdihYHBMI/CCD3sy+z0eAQ40oWJ0zgH7OPY+bv5CFBPVse71psOwcu63mgMyCghmN1M0JMrGn2/bHY8SrjlAsuTuVGz9We6gsqHBoB4F0GaE0AVLy65jP3DfkroSOOd9kSpj1h6kYMxtavE+CqqcwvxQ3jNUrjkNNVUtDzI4gK3rucuz0wIotqfNhvn8KulomahTidGU1tIP0ytj/yBnKI15MEbRj+B2nCmAtG68u6VE8nJaOxLMZonoAsH+9R99IXw4O0RaRhobl2Bm3Ep6FoVeGYUqD2f4Q8jYnmy024i6Y+0Z+VhcxivCppP2g7svKsVZmmERw3dGcBb5zGt3VSzystSXWtB9VXyeuDfjw5W0IItVQ3/YpdAUGpllh9rbMbyiL8C4TNABCxd9C/4AbUyvwZlTSk66T/caE+Q==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9e3ca4a-f3a6-49fe-ba92-08d85ef762dd
X-MS-Exchange-CrossTenant-AuthSource: SN1PR12MB2590.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 12:59:48.5234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: btTNDjzpxCfcbeLtE5GzkmyD5gJn1Uf6pW+MXD5ks4YqyEnI5ILvOEfzS7R2yzvwTxe0PFAVubuBQexP3yltBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2557
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Mon, Sep 21, 2020 at 01:34:35PM +0200, Pavel Machek wrote:
> Fix resource leak in error handling.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>

Acked-by: John Allen <john.allen@amd.com>

> 
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index bd270e66185e..40869ea1ed20 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -1744,7 +1744,7 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
>  			break;
>  		default:
>  			ret = -EINVAL;
> -			goto e_ctx;
> +			goto e_data;
>  		}
>  	} else {
>  		/* Stash the context */
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany