Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 1rzj7wiGIESeyBPUJjyYS4yAvrEz+2h4tamFV7dhDlyfvecNOSsaAucbhtP0avjkKOTI6Wby8W
 3kcKhqhktlzg==
IronPort-SDR: bBOY5IvAKE2dR2qVgHLTeShCzoEoiUVlwhF51qMH4jQUljnyomKZJ6kdMuerYJoXUYQBVUlmYl
 61Xg+3Ko6EOw==
Date:   Thu, 24 Sep 2020 06:03:46 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        qat-linux <qat-linux@intel.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] crypto: qat - remove unnecessary mutex_init()
Message-ID: <20200924050346.GB32206@silpixa00400314>
References: <ee44c6c05720495d8bb72ae9ad7094e8@irsmsx602.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ee44c6c05720495d8bb72ae9ad7094e8@irsmsx602.ger.corp.intel.com>
Precedence: bulk

On Wed, Sep 16, 2020 at 07:21:21AM +0100, Qinglang Miao wrote:
> The mutex adf_ctl_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

> ---
>  drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> index 71d0c44aa..eb9b3be9d 100644
> --- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> +++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> @@ -416,8 +416,6 @@ static long adf_ctl_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
>  
>  static int __init adf_register_ctl_device_driver(void)
>  {
> -	mutex_init(&adf_ctl_lock);
> -
>  	if (adf_chr_drv_create())
>  		goto err_chr_dev;
>  
> -- 
> 2.23.0
>