Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp290285pxk; Thu, 24 Sep 2020 05:58:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRIODC9g7OTTQHcM19o1k9iElnJPhOp1eoqow/AJbEO0gwxM4x/lXAdxEQ5Z/DWna8gAxY X-Received: by 2002:a17:906:aec1:: with SMTP id me1mr902957ejb.225.1600952334409; Thu, 24 Sep 2020 05:58:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600952334; cv=none; d=google.com; s=arc-20160816; b=llW9x4YEgvDH/IJ7CD+BYrzZqKYQNsULYZmI79QMWVphMhmynXvvGc1t40l6YyMZka 97pvvpnTgvhuPX4Ve3QeSwCQpAVFuKNQyzusvO2eLDjn3nrFcgf3Q/V7kVk06wKI+LyO Ao2m3eQjewqbMdBwy/jcy1wl4TCaClFY2lZL2zZHXhV6kX7A+ss/MBNwHjjwl57A7Rjl eP2AsDHLyZEXM/YQhjNzHFnggGVNFGWWntuVHmcDhMYXyxxRscowz9oJqCO4A/Jdelu5 +3Ef0FCGpQh9TfDfQBhS6/xTnEdlQ6zZWcNOCrypvC525PCYr+1M35BUTQW0j3x3a7PW XC0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DL4a5sJAS5QQAonvD5huNnnz1Utl1S6OSeTll7lZsjc=; b=hZKIjQGRfIYRQdU4W1tHHZ4PIrw3O2pJasVFQhfuOJGRBHE9xImn5JT6W3ooHK11ku xUANu2TeJDqprBD2p3l7rXcR37Eq5ihJYtIe8CLvS7LVpG+8karklCVLVj8z0bjCflAE e3w3aMJP4fm/4WFPooKie4jIVd82LikT3DX0MTH5IBpx+lilgZ7j1JI78iP2ho2qUo5B XMMneboxI9fVqGOXxrpgjmmKRU9tYIoTQCu4hcoK/PhHgCJXG/KU2g1YnOQg7PjrpaD8 8NVHzWA+CZ4Tco7mWt6eDNXH0Vwp2fU7V+2i/UBGwckJECU0g0FDtv4gX6e12LPS/ZHC 5QLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me14si1777714ejb.397.2020.09.24.05.58.29; Thu, 24 Sep 2020 05:58:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727748AbgIXM60 (ORCPT + 99 others); Thu, 24 Sep 2020 08:58:26 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50124 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgIXM60 (ORCPT ); Thu, 24 Sep 2020 08:58:26 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kLQpJ-0002lv-PD; Thu, 24 Sep 2020 22:58:22 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 24 Sep 2020 22:58:21 +1000 Date: Thu, 24 Sep 2020 22:58:21 +1000 From: Herbert Xu To: "Van Leeuwen, Pascal" Cc: "linux-crypto@vger.kernel.org" , "antoine.tenart@bootlin.com" , "davem@davemloft.net" , Ard Biesheuvel Subject: Re: [PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems Message-ID: <20200924125821.GA11034@gondor.apana.org.au> References: <1599466784-23596-1-git-send-email-pvanleeuwen@rambus.com> <20200918065806.GA9698@gondor.apana.org.au> <20200918080127.GA24222@gondor.apana.org.au> <20200924031154.GA8282@gondor.apana.org.au> <20200924123559.GA10827@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Sep 24, 2020 at 12:51:11PM +0000, Van Leeuwen, Pascal wrote: > > But you still have 2 potential gaps (from buffer 1 to buffer 2 and from buffer 2 to > the other items in the struct) that are larger then they may need to be. So put some of the rest of your struct in the middle, up to 128 bytes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt