Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1239506pxk; Fri, 2 Oct 2020 04:55:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9fEOmrootfZRjAmsVZgQDgISDjumi3HBzEtKxlEx8KatCGYkN5rtRfWqUVBPzrouyupYu X-Received: by 2002:a50:cbc9:: with SMTP id l9mr1838173edi.310.1601639745624; Fri, 02 Oct 2020 04:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601639745; cv=none; d=google.com; s=arc-20160816; b=WOU/W+IBPgWQY79W82O8pmh0O96xrTJTac6oTMaovBmUYvwoev/Vq0E0svHucoVuC4 rr2j8sBy46ouUNKLPTNe192h0aVM/ORHb9efwX3ZaTOAMwhb4ohycPVK9GRweYP/ecl8 Ml/GBtTWeDJ4n9qreurTSlfMBVutlrHc/+Cz9ezLx0Nzd470SY7rLBdFSjykg/63F04H dEloRFA62NdAwIddsLfn+kGGM/7qWDkQXUqT/IPzPHXvy9BPOTDo5MtjGttbffmHlO2p wuguDR9Car303lPQqaSnOUlzcOR+ImkrwmqrYaLJy79oY0cHw8o0Oi6xgdLqS9eMC/SE SdCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6OMa2PcY7LlHDNMoTtgA3v8HHAnrvLiccfmjOEvjldk=; b=bsPWKw/u/XEJyyIxu9y+7tPGqQbInir7sII+tKmf0evKrSE4xonFIwpgNw471G5ZAp baCHXakfBjB+BqoBoYa7R5KMpIKnfJ3YGMgPSaNhrjTGSH1GPPfQwekCHkxaQzYu8zLt NV8Mz87mmMk3uO2tjr8bmv1qsMbDk0CfGsKVJB2Lsu4hxRJ7rrhdEv8/JSfqtT8dFwCa pwrQa0Fjja49ondfA1ZV+TRqsDlOy9U8p98PKgm94y3cC8nTrF2YSz/Nf2DF4Y3XDi3F LcZnc5s6ic6mqmhhjl9NZtnc8DgIxT81fiROE7Qc82t0lhrVUQThwCa4ybLRVC9wE7eb C05w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch15si1002027ejb.264.2020.10.02.04.55.22; Fri, 02 Oct 2020 04:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbgJBLym (ORCPT + 99 others); Fri, 2 Oct 2020 07:54:42 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:49142 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgJBLym (ORCPT ); Fri, 2 Oct 2020 07:54:42 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kOJdx-0005Pr-IS; Fri, 02 Oct 2020 21:54:34 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Oct 2020 21:54:33 +1000 Date: Fri, 2 Oct 2020 21:54:33 +1000 From: Herbert Xu To: Andrei Botila Cc: Horia Geanta , Aymen Sghaier , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/10] crypto: caam - xts(aes) updates Message-ID: <20201002115433.GE1205@gondor.apana.org.au> References: <20200922160328.28926-1-andrei.botila@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922160328.28926-1-andrei.botila@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 22, 2020 at 07:03:18PM +0300, Andrei Botila wrote: > From: Andrei Botila > > This patch series fixes some problems in CAAM's implementation of xts(aes): > - CAAM until Era 9 can't process XTS with 16B IV > - CAAM can only process in hardware XTS key lengths of 16B and 32B > - These hardware limitations are resolved through a fallback > - CAAM used to return 0 for XTS block length equal to zero > > This patch series also adds a new feature in CAAM's xts(aes): > - CAAM is now able to process XTS with 16B IV in HW > > Changes since v2: > - modified xts_skcipher_ivsize() based on comments > - squashed the previous 7-9/12 commits > > Changes since v1: > - use only get_unaligned() for calculating XTS IV size > - fixed the double calling of crypto_skcipher_set_reqsize() in case of XTS > - added a patch which modifies the return value for XTS when block length > is equal to zero > > Andrei Botila (10): > crypto: caam/jr - add fallback for XTS with more than 8B IV > crypto: caam/qi - add fallback for XTS with more than 8B IV > crypto: caam/qi2 - add fallback for XTS with more than 8B IV > crypto: caam/jr - add support for more XTS key lengths > crypto: caam/qi - add support for more XTS key lengths > crypto: caam/qi2 - add support for more XTS key lengths > crypto: caam - add xts check for block length equal to zero > crypto: caam/jr - add support for XTS with 16B IV > crypto: caam/qi - add support for XTS with 16B IV > crypto: caam/qi2 - add support for XTS with 16B IV > > drivers/crypto/caam/Kconfig | 3 + > drivers/crypto/caam/caamalg.c | 94 +++++++++++++++++++++--- > drivers/crypto/caam/caamalg_desc.c | 27 ++++--- > drivers/crypto/caam/caamalg_qi.c | 94 +++++++++++++++++++++--- > drivers/crypto/caam/caamalg_qi2.c | 111 ++++++++++++++++++++++++++--- > drivers/crypto/caam/caamalg_qi2.h | 2 + > 6 files changed, 293 insertions(+), 38 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt