Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 21:28:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Jeremy Linton <jeremy.linton@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org,
        ardb@kernel.org, will@kernel.org, catalin.marinas@arm.com,
        davem@davemloft.net, herbert@gondor.apana.org.au,
        linux-kernel@vger.kernel.org
Subject: Re: [BUG][PATCH] arm64: bti: fix BTI to handle local indirect
 branches
Message-ID: <20201005202840.GJ5139@sirena.org.uk>
References: <20201005181804.1331237-1-jeremy.linton@arm.com>
 <20201005195957.GF5139@sirena.org.uk>
 <c554e7cb-2773-a49f-a126-fdc56be029ca@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LG0Ll82vYr46+VA1"
Content-Disposition: inline
In-Reply-To: <c554e7cb-2773-a49f-a126-fdc56be029ca@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--LG0Ll82vYr46+VA1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 05, 2020 at 03:10:42PM -0500, Jeremy Linton wrote:
> On 10/5/20 2:59 PM, Mark Brown wrote:

> > ...this is going to cause problems, SYM_CODE means that we should
> > assemble *exactly* what was written since it's some non-standard thing -
> > we use it for the vectors table for example.  Looking at the code it's
> > not 100% clear that the best approach here isn't just to change the call
> > to a regular function call, this isn't a fast path or anything as far as
> > I can see so it's unclear to me why we need to tail call.

> Well for some workloads its could be AFAIK. OTOH, Ard mentioned dumping the
> tail call too, and I think that is pretty reasonable. So it looks like that
> is a better plan since it also avoids all this SYM_ flailing.

Yeah, I think that's the easiest thing all round.

--LG0Ll82vYr46+VA1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl97gfcACgkQJNaLcl1U
h9AGKgf/TpwsU5LActmSW1rJZkGgZPIPBP+iIcOuBL8Y5mjrzR3NagJHB5Du4BwG
hgBKU5KYqasnZMpmoWOnjPY9j+N1KJmK3ew4VCHARKX4PSQN8KukRTCXWDmRe0UK
F6drKioPyA1gnLOAjfEkKiLIGwFPbU7/KFeOY9Oe8bUELZyBgz7Jta8ipXR7sX5F
sHcy3PXcPTqx3HUPYFtQHDZkECWL2/ckpdCsYfCj/iqald9xGo2PQiulZSWUfRxK
//tCe0g/kVn2aGqHMhjs02VP98n0tiO0Z6SnlJahmTtjvDluONtGIAKhYsPjOAs6
1Fc2NVJRnkghtsY6HaoX1WMS91ghkQ==
=SIFO
-----END PGP SIGNATURE-----

--LG0Ll82vYr46+VA1--