Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp169457pxu; Tue, 6 Oct 2020 03:37:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypoaYt+8dLgvH4LYvJUbeQpvyb7xrTGJ8DsXk1EGyXsa2KWe50GuUSta2pItywVpyCRhsJ X-Received: by 2002:a05:6402:1716:: with SMTP id y22mr4504917edu.241.1601980627740; Tue, 06 Oct 2020 03:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601980627; cv=none; d=google.com; s=arc-20160816; b=CqC67qGPKD4eikwJa+6Omi1w85gbyUjz6IL3DLExmKC8e0ulqthXVPmI22UtkIM4xq pEBlO+Y1qYTY6yBQlu/KJuE+ILtN+JQHL3FmTkyG8ae8GxN4RV4lsFee7Rl6rh3nUy+H RSO4vcb2WqZ9+YHE/8YJIEhyKD3R0Y2sR4MnVJel179VtEs46e0U3AJsNbsNW+gAepc7 FoDI7Wy9yJAefhdJ9m3V2XfZjHeSSZ8XE+Ljfn49rWJ4j9kNg75o0lj8Mu8vo1L3gnIg 44Wcmz6DCg4MEaCs6TOCK+tmNVCd9hiBw8JlQOYE8K2wgJ1ttqGSfTBAYfdmF0w0WNhb gjrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PQR6Uxb0nhKxapVOyR72S8ZRuO6rYgI0q0HVtWS+SLw=; b=YYJ/nRU3hqcQlQZAn2qID4BRvrlbnyyVc8PYIYLOb2UIBE7sC203LDeg5+/BXWwxlr il3Yt/jSfCdiE3xrogPr0DmoguL6o9iZt9tZ1ibwaABUbxoDJ+E4fVWIVTI6NP4Bi89t v9watsOLmnHPk5NL99rL4R3rayjOFga9Yqtjin6iiT6WNvLJ1dNRcLE1HCg7xPRWUUPu bm2eTrwyhfsiwVzHD60tmGpGKjGgZbRPryyIZIZ0X8yi8mrdmJ6I6NuFUwcBn2uBE7EF 8+TcB+AaUxYoRWesM67w7KEnBqa/vonabYwNQPbFWqi+uELZUzuHFQwtHH7q/SnXTYOS 1JFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KqYOAPRe; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si1756424ejp.191.2020.10.06.03.36.37; Tue, 06 Oct 2020 03:37:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KqYOAPRe; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbgJFKgM (ORCPT + 99 others); Tue, 6 Oct 2020 06:36:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:36220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbgJFKgM (ORCPT ); Tue, 6 Oct 2020 06:36:12 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4231B2080A; Tue, 6 Oct 2020 10:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601980571; bh=PQR6Uxb0nhKxapVOyR72S8ZRuO6rYgI0q0HVtWS+SLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KqYOAPReH7n44rGE3eR/7G8NJ/kciOyAi89FCE5ICAvLmdYAY4y5Jko+Xpjh5cWnA 4l0JLCPa06YEbZ4dO3gzyiMf+PmUFLUHjDj7H+lYQH6QkAkZwWJqHvYKx2dL9HZ3Yw U1WTtryX+e5tsaolPiyztZK4vULw7Wbr38Tm4Ckw= Date: Tue, 6 Oct 2020 11:35:08 +0100 From: Mark Brown To: Jeremy Linton Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, ardb@kernel.org, will@kernel.org, catalin.marinas@arm.com, davem@davemloft.net, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org Subject: Re: [BUG][PATCH] crypto: arm64: Avoid indirect branch to bti_c Message-ID: <20201006103508.GA5259@sirena.org.uk> References: <20201006034854.2277538-1-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <20201006034854.2277538-1-jeremy.linton@arm.com> X-Cookie: Will it improve my CASH FLOW? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 05, 2020 at 10:48:54PM -0500, Jeremy Linton wrote: > The AES code uses a 'br x7' as part of a function called by > a macro. That branch needs a bti_j as a target. This results > in a panic as seen below. Instead of trying to replace the branch > target with a bti_jc, lets replace the indirect branch with a > bl/ret, bl sequence that can target the existing bti_c. Reviewed-by: Mark Brown --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl98SFsACgkQJNaLcl1U h9BMrwf/RiJaQYvD/q24Fy2YkxfBrOM7a14fYbCR6mSTUD1AauKZxhnZcdF18CgJ EOJ5dddU832+k7MJxQIlLmtfYMFrP3wu6f+uxQH4Ft4q6MGXNhMjAJcmiGoZsVdG 5LCtaCxJrjzFMl7t30C9G1OCFU2YdBDVNeKVsgpgRROHKNfk7mnZJdxbX/HPNmkb 8mhjE4CazgyLRrp5goweWCi/nGc0uPKnfLqiGgJRpfEskB/y8jBvrQ3EaTEnnxFp +I/Wzej1o4QCE1QKYYMQr0Y+lQsAih9kcvVDJgETlwyXgYgcTo3kL2TTCT9pMEaQ qKa+msQKZvs+bWYZPCQp9Un+hZBzpg== =LGy1 -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--