Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp429677pxu; Tue, 6 Oct 2020 09:41:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeu3VIiBnU0RJJDNUXKSu0+Ml0M1p1/+ZJJD9L+x0lMqrOeO4lQXozDbxpGntpO0UPocXV X-Received: by 2002:a17:906:7e52:: with SMTP id z18mr430465ejr.186.1602002485859; Tue, 06 Oct 2020 09:41:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602002485; cv=none; d=google.com; s=arc-20160816; b=UZoeYl4ofIqNLfgcQvuF3xlPYO4K5ENKh8f1iAOoRONsT3dFp5t/pSxNiF1HPc4XVd d4epg1v4LhHaG7343dSXY1lkVTmQii4L05tb46JrxyAOurd3p7n1Wr4r7BA6CuXAk33s ZX1Y7PUoFSgk8Og2ScyyM9xvpEdWw9fjgEYC5fuLBrAvQ4RAnTVwuqiHCP0ZbtKhiI4k 3CrbLXHjnR8IHIUHP2cqMfg/0ZX2rX1XwnZkPDgr3gYOgqW/zeBi2W9iq105j1oc8hNq npkfV/m6CzEaJKXZw17wrY5oKl5aNHvxwp98FZOOmN1Wsp5ul1fXINSE1KzbGVAJWA1W z86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7Kafi3SMR5wUFUKEpxTCLbAGQeHhDJktANYroBfi6As=; b=H5aJTkXALtp9bAMQ7MAIJdowm39ZGpgDDRieILfhPzbSImvPwpDzpQhTa36X/qmTeH ZCgr/ICMh/+wtkSRzB13J9zyzmNHxiN6ffLGCi1HSP/wq8n4oZn4e0qCvNnT2nioT3yW nghU5bW2nHYImr7kG0SN1v9PXvWEEhGKb3hnM1yEOhkeFxPYVo2qV/UU8CzmP4RS2vaj LOru+iYg1gKGLjpKzLspQ3SUA24sn1JH8I4Zz9A2SOkpLSH9O5HNJ2cKIeqkiDDXe3Jr 4Cz4pjsfpfNt9XEIFuoqWTxxDTr8kyKZKDLPO/pYMl4UK6xnBi7w6OviPF32MQ2TeMP5 qW5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=esAOhbLY; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e2si2836080edl.476.2020.10.06.09.40.59; Tue, 06 Oct 2020 09:41:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=esAOhbLY; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725972AbgJFQkr (ORCPT + 99 others); Tue, 6 Oct 2020 12:40:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgJFQkq (ORCPT ); Tue, 6 Oct 2020 12:40:46 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15BFE206F7; Tue, 6 Oct 2020 16:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602002446; bh=7Kafi3SMR5wUFUKEpxTCLbAGQeHhDJktANYroBfi6As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=esAOhbLYNjHKVB6XxpntZ8n20rm3hLJNEB7/6dx2pGzfPGg33K333ks/65mtGEmwE tIKJ6ax7tFOX6yZPuRS9fhopfGdDXuuaQcRC1QKqseQpvQ/3L2xpGj/+AIWaa6ZwBC BdgA3S2b2HvadrKup2Ez5dDhYYNGXu2R3iLKFyNw= Date: Tue, 6 Oct 2020 17:39:43 +0100 From: Mark Brown To: Jeremy Linton Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, ardb@kernel.org, will@kernel.org, catalin.marinas@arm.com, davem@davemloft.net, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, dave.martin@arm.com Subject: Re: [BUG][PATCH v3] crypto: arm64: Use x16 with indirect branch to bti_c Message-ID: <20201006163943.GD5259@sirena.org.uk> References: <20201006163326.2780619-1-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4" Content-Disposition: inline In-Reply-To: <20201006163326.2780619-1-jeremy.linton@arm.com> X-Cookie: Will it improve my CASH FLOW? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --6Nae48J/T25AfBN4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 06, 2020 at 11:33:26AM -0500, Jeremy Linton wrote: > The AES code uses a 'br x7' as part of a function called by > a macro. That branch needs a bti_j as a target. This results > in a panic as seen below. Using x16 (or x17) with an indirect > branch keeps the target bti_c. Reviewed-by: Mark Brown --6Nae48J/T25AfBN4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl98nc4ACgkQJNaLcl1U h9CLAwf9FiPQZ/xkGSQroau0bLLgKubdsRTXCnzajbWymLdZcF7NPVkEqC61rY+X hTAWXCf2S9EtKxSV93rO0ea9HsRomillICgvVTDfk0tn4AOz8d60dTNtMaMuwQZ4 qlOxUBnkMk1XL4QoOiY5X8G9APy/sEIcZas0GqobABxmnRA1DduxLQtfF5x0BRoO BKhSQ2v3nHThDpOJ5ati6KAq3R3IdAtgzPt02Y6K28RXRXktAUbtcPJFMMCEWPox XylPKGq4FGqFWGEoeGAdf+6vcT3v1A40fSp9WvX94RO43YuJfJhSjwUVcDApiXSX BVagPfdEIahk4NrD2q4kDgQW3Z7Tsg== =eHIP -----END PGP SIGNATURE----- --6Nae48J/T25AfBN4--