Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Srujana Challa <schalla@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Suheil Chandran <schandran@marvell.com>,
        "Narayana Prasad Raju Athreya" <pathreya@marvell.com>
Subject: RE: [EXT] Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load
 microcode and create engine groups
Thread-Topic: [EXT] Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load
 microcode and create engine groups
Thread-Index: AQHWoIa6AHfVkGFIKUGTzj17hQ9DR6mXzPkAgACLdzA=
Date:   Thu, 15 Oct 2020 08:29:30 +0000
Message-ID: <BYAPR18MB2791FBC1851E0488FE328FAEA0020@BYAPR18MB2791.namprd18.prod.outlook.com>
References: <20201012105719.12492-1-schalla@marvell.com>
        <20201012105719.12492-8-schalla@marvell.com>
 <20201014170622.6de93e9a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201014170622.6de93e9a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6b5807-52ab-47c1-7fe2-08d870e46fd7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 08:29:30.2854
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X+nS1b33vbNsCEzF42w5IYFrTbjrmLz1F2uyXp+yhkGwc73RoJ1svlFvY3ght6HIdyY28Uo9Fg9PmvhKhyfOxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2661
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-10-15_03:2020-10-14,2020-10-15 signatures=0
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> Subject: [EXT] Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load micr=
ocode
> and create engine groups
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Mon, 12 Oct 2020 16:27:13 +0530 Srujana Challa wrote:
> > +/* tar header as defined in POSIX 1003.1-1990. */
> > +struct tar_hdr_t {
> > +	char name[100];
> > +	char mode[8];
> > +	char uid[8];
> > +	char gid[8];
> > +	char size[12];
> > +	char mtime[12];
> > +	char chksum[8];
> > +	char typeflag;
> > +	char linkname[100];
> > +	char magic[6];
> > +	char version[2];
> > +	char uname[32];
> > +	char gname[32];
> > +	char devmajor[8];
> > +	char devminor[8];
> > +	char prefix[155];
> > +};
> > +
> > +struct tar_blk_t {
> > +	union {
> > +		struct tar_hdr_t hdr;
> > +		char block[TAR_BLOCK_LEN];
> > +	};
> > +};
>=20
> In networking we've been pushing back on parsing firmware files
> in the kernel. Why do you need to parse tar archives?

We have 3 variants of crypto engines and each uses a different firmware fil=
e. So instead of 3 independent files in /lib/firmware, we have a consolidat=
ed tar file. The tar file is a container.
Minimal parsing of firmware file is required to ensure parity between engin=
e, firmware and driver. For example we verify version compatibility.