Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1038804pxu; Fri, 16 Oct 2020 02:09:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNn7f4KDZ+1DCC3aBE/qilEm2lgE5pW8OicZyF/qWs54dOLAPGNg3sT0cXf9aETn/1OBA6 X-Received: by 2002:a50:e881:: with SMTP id f1mr2800775edn.58.1602839357211; Fri, 16 Oct 2020 02:09:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602839357; cv=none; d=google.com; s=arc-20160816; b=mGJjb75TeLeS5immMtVyj/TEV6c0JYyFf/d9wp7h/RS7yGYbM2zLGTpRwT3cX0F8lp cXMRYW/ClMO5XnastYfdOnAwWYdkeExSnLphrdOjjUfa0oZrzI5wO0lVdZ58Chcc9Nwj bFJc3Aw38dzT5Z3nvtsHW/bm57aCc48p4Qf7EGVP30pXZcjFptir6GS3RhTKhjRagucE VyuKSckGPaRysuXwI45hgBEBR7Xn8xjmyaDXe9v9lQSrZDVH+YcoaLVpolyFuFHzE0FZ h2QIHn+PgP+m3ICKL+nFJ7ifs0eAy0EtdxmCAyb9GaZQq09B2PSCSgK0UHmn00z0zRCH j0cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1oDnzBef9YYFyrmh4dGn48pmidfRtzCye+v5WkMWbZ8=; b=i0aMv06k598DYKaP68/SfZTIb4ksaG6RDRdoW1MHs+4iMHU6To0vB8509UqJyKsf2/ X/rOt3tWnS3Xm/bF/p8e7SxKKEsnuDV/sPZvtp1st73HJ6GE/aiiscNEPPL3Pw7bbRhL 1lbNZggQAliAiUkY6eRAL6Bb2uXhG2jXeHK6jGky2prCEZH+r0sfRxCC4/eP4wIY1xXf L1Grxyf/TYi1R44NRirq3JieTQH6kq74d7gXBhaudm/XeEdT5z8nOuQe3t5mUB8C73iF 0PIHt9W/qh/7UTUHBd2RngS6wiEGp9ViHlg1uKeFGAjOt7JlsjVKIh+LBa+3s58He9QV 083Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si1212328ejy.684.2020.10.16.02.08.47; Fri, 16 Oct 2020 02:09:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405226AbgJPIzJ (ORCPT + 99 others); Fri, 16 Oct 2020 04:55:09 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15304 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405225AbgJPIzJ (ORCPT ); Fri, 16 Oct 2020 04:55:09 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 75BA238663DEA170B9E6; Fri, 16 Oct 2020 16:54:58 +0800 (CST) Received: from huawei.com (10.90.53.225) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Fri, 16 Oct 2020 16:54:54 +0800 From: Zhang Qilong To: , CC: Subject: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device Date: Fri, 16 Oct 2020 17:05:36 +0800 Message-ID: <20201016090536.27477-1-zhangqilong3@huawei.com> X-Mailer: git-send-email 2.26.0.106.g9fadedd MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org pm_runtime_get_sync() will increment pm usage counter even when it returns an error code. We should call put operation in error handling paths of omap_aes_hw_init. Signed-off-by: Zhang Qilong --- drivers/crypto/omap-aes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 4fd14d90cc40..70ea5784a024 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -105,6 +105,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd) err = pm_runtime_get_sync(dd->dev); if (err < 0) { + pm_runtime_put_noidle(dd->dev); dev_err(dd->dev, "failed to get sync: %d\n", err); return err; } -- 2.17.1