Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 18 Oct 2020 18:29:12 -0400
From:   Nigel Christian <nigel.l.christian@gmail.com>
To:     mpm@selenic.com, herbert@gondor.apana.org.au,
        yuehaibing@huawei.com, hadar.gat@arm.com, martin@kaiser.cx,
        arnd@arndb.de
Cc:     linux-crypto@vger.kernel.org
Subject: [PATCH] hwrng: imx-rngc - platform_get_irq() already prints an error
Message-ID: <20201018222912.GA90387@fedora-thirty-three>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: bulk

There is no need to call the dev_err() function directly to print
a custom message when handling an error from platform_get_irq()
as it prints the appropriate message in the event of a failure.
Change suggested via coccicheck report.

Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
 drivers/char/hw_random/imx-rngc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 61c844baf26e..69f13ff1bbec 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -253,7 +253,6 @@ static int imx_rngc_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq <= 0) {
-		dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
 		return irq;
 	}
 
-- 
2.28.0