Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5415349pxu;
        Thu, 22 Oct 2020 01:25:30 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwauL1FkBs2Xk/2KFnBkXcg6Eu1WteNFsE0W3eYsCTGbEogfUJRG6oE8x7arElqQXyjobl2
X-Received: by 2002:a17:906:d0d4:: with SMTP id bq20mr1201750ejb.257.1603355130187;
        Thu, 22 Oct 2020 01:25:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603355130; cv=none;
        d=google.com; s=arc-20160816;
        b=Ko8m3LHkuRFFhP74RCo2iJ3szgD3b5dEDTOnCqYU1T7e4jIB+RLWW92E0g26dnaIcb
         7l6ESNs1+nhEXMXkyQb84BRDMnEFYRbehlXQAQCmga46x0KoSX5pPJn+YMXlqyMG/Oi4
         aiYTM005xT3uP/NwCwZnrT4KukbcOfCmTFoIjixTHNKCKLDWQKYoijPp4stelaFF6Zg6
         9gbi8j9Y5fxfbhEMKmTWk54aKD1xXW8eNlTMfwpR9NxznOx3xVD9Xh5b8RdHUp3ADsLT
         UL7Vfd4LmwE7DmGyGhoORX/gU8VHcyb6YJNEfPkO/T8lzsy3wO+9dotBTucUsaA1Pyyz
         AkKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=6RjGm1Luk8dw+4jlCfz+C9QIEVxYMlzsTw/se2bvuis=;
        b=Wk7ugVNaP/l3/vZ3Jpb+E5aAKrzKCI2/DUB4JyCyN+j259RZP+bLqyi1Ff/I6KnvcV
         dgdnKZhn+i6GiyYZNvQyjFX5ifREn0fDLEwYWY3Lp+9jqwL/27UK2p0xTs7FUnBLruPp
         ohgD/LHzyolbrEeIDHTSAjr3Z93V6oqsUGor7onMPlWg65NX9WyDcuUIIcyqKyLuhdcS
         nQya8rcMXJaD49ICjh0/nySyxF9sC9FSfnzcBWJRNroJlKJbpX/+2gejS/gFb9yxsvoP
         Mz5rw77J9aqGQnMZMiq48Rk4/sIKuu9WP1TG6FzlbSM9dryLZg3zwygt+ylDAMR5B9+Q
         rE7g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=uSeZLdbv;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id j19si538434edr.278.2020.10.22.01.25.07;
        Thu, 22 Oct 2020 01:25:30 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=uSeZLdbv;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2507707AbgJVFC7 (ORCPT <rfc822;christopherhkane@gmail.com>
        + 99 others); Thu, 22 Oct 2020 01:02:59 -0400
Received: from mail.kernel.org ([198.145.29.99]:60598 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2507705AbgJVFC6 (ORCPT <rfc822;linux-crypto@vger.kernel.org>);
        Thu, 22 Oct 2020 01:02:58 -0400
Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C452D20657;
        Thu, 22 Oct 2020 05:02:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1603342978;
        bh=grOL9UzXnA0JO4eRDSJG6Nrn9WZXrL2VbgFYaFjGelE=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=uSeZLdbv2dG9Cs3UKg1lwf4W9cFcRN148Z/ZyujpikqHGI1YlMy4pgiIcwe/N7aXN
         W5UHrq2DJ9kArqNIuXQnC/XUEtLEG7wHjNl/GpzpxE1Tt1fSsW7d0plBGT9oXyE+MM
         degOUYvnD+2I7jyjBpwqwFeb1JxVJ6zQNbx9wAgU=
Date:   Wed, 21 Oct 2020 22:02:56 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Arvind Sankar <nivedita@alum.mit.edu>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        David Laight <David.Laight@aculab.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] crypto: lib/sha256 - Unroll LOAD and BLEND loops
Message-ID: <20201022050256.GH857@sol.localdomain>
References: <20201020203957.3512851-1-nivedita@alum.mit.edu>
 <20201020203957.3512851-6-nivedita@alum.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201020203957.3512851-6-nivedita@alum.mit.edu>
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Tue, Oct 20, 2020 at 04:39:56PM -0400, Arvind Sankar wrote:
> Unrolling the LOAD and BLEND loops improves performance by ~8% on x86_64
> (tested on Broadwell Xeon) while not increasing code size too much.
> 
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---

Looks good,

Reviewed-by: Eric Biggers <ebiggers@google.com>