Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Oct 2020 21:44:56 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Zhang Qilong <zhangqilong3@huawei.com>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        nicolas.ferre@microchip.com, ludovic.desroches@microchip.com,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH -next] crypto: atmel-sha: discard unnecessary break
Message-ID: <20201026204456.GC75353@piout.net>
References: <20201026134807.13947-1-zhangqilong3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201026134807.13947-1-zhangqilong3@huawei.com>
Precedence: bulk

Hi,

On 26/10/2020 21:48:07+0800, Zhang Qilong wrote:
> The 'break' is unnecessary because of previous
> 'return', discard it.
> 

This is a duplicate of https://lore.kernel.org/linux-crypto/20201019193653.13757-1-trix@redhat.com/T/#u

> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
>  drivers/crypto/atmel-sha.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 75ccf41a7cb9..0eb6f54e3b66 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
>  		break;
>  	default:
>  		return -EINVAL;
> -		break;
>  	}
>  
>  	ctx->bufcnt = 0;
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com