Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1081388pxx; Tue, 27 Oct 2020 07:52:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJlaVJPnbQzgwv8ZmpBhDSEdmXdDKLkkbANmB9JaZzQMkxLSQkB2xya7aRRV02pqS6m6N2 X-Received: by 2002:a17:907:42fb:: with SMTP id oa19mr2691074ejb.447.1603810359115; Tue, 27 Oct 2020 07:52:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603810359; cv=none; d=google.com; s=arc-20160816; b=xHBJcZIfugmw7NQGIQ1H3AlPA83wvt+4wuhc0fHJKUew4toJ8e8Qh0cFY8K/rB+H+N fAMM+Bv9pvhvHQWBQrgfLlQpOqxZfAFkcYNNslurqCgkq4Iapk408CUKV1d1z8zHSZ6q 7+07XPpl/mqA79fh4FGTMT7uBcE+gzOdRejnOagBwrgwc0t3sRuigSQiE0pZHIZIUuUl M9FFfazRMNdc2yEra7sgsRsoz6IemSmQl9PZNzon9EKEreenAY+Ec4xC2id9pvaI17m5 HP2Kfz4wmHi9914EWfXEEx+Jvcmci9Hjn9VmUUwFgyD0NNGypXZ5yGpI9+7bdzdAW7RH x84g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1oDnzBef9YYFyrmh4dGn48pmidfRtzCye+v5WkMWbZ8=; b=xuzg7QAMld4ZMGlJorMgA3H5X+qeQp4Ug4bRvrdqJgEDHYecj4oYu54cYKrZudZkdJ oHudftF2rk6agsxFMWnaO15SqH9kb7hbjW7pfKQ659PCKFlUi45chcR8mDym2JOCCyph QAYlPyO8TgiYH2OO9d36vWKbDtOF/tk2JCt7Kz/W774B/etiLsYp4fr4dk1hN3XWBUNT eK8wff7Zkrm51Sk6S8hc2Z/GhgL7dRq1Xv9/uNO0bbBiFWV/dOTLhLulCm1a0wY47wE1 4iCO8M7ggMopNgUCwYV9gjrKce0bibE3wgk+9Ekkss65EYteW0ANcF+sHFR9+i83QUAR lavg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si1145647ejh.223.2020.10.27.07.52.15; Tue, 27 Oct 2020 07:52:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2900552AbgJ0NOi (ORCPT + 99 others); Tue, 27 Oct 2020 09:14:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6158 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2900542AbgJ0NOi (ORCPT ); Tue, 27 Oct 2020 09:14:38 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CLBxf1tGgz15L49; Tue, 27 Oct 2020 21:14:30 +0800 (CST) Received: from huawei.com (10.90.53.225) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Tue, 27 Oct 2020 21:14:25 +0800 From: Zhang Qilong To: , CC: Subject: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device Date: Tue, 27 Oct 2020 21:25:10 +0800 Message-ID: <20201027132510.81076-1-zhangqilong3@huawei.com> X-Mailer: git-send-email 2.26.0.106.g9fadedd MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org pm_runtime_get_sync() will increment pm usage counter even when it returns an error code. We should call put operation in error handling paths of omap_aes_hw_init. Signed-off-by: Zhang Qilong --- drivers/crypto/omap-aes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 4fd14d90cc40..70ea5784a024 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -105,6 +105,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd) err = pm_runtime_get_sync(dd->dev); if (err < 0) { + pm_runtime_put_noidle(dd->dev); dev_err(dd->dev, "failed to get sync: %d\n", err); return err; } -- 2.17.1