Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1080689pxx; Fri, 30 Oct 2020 01:09:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza9Gv1KpIijEj8gFjjRTnQihvsSAv7v8T08lTklfOwh3dE0vGlwtE89/bk78yZy3BlnGk5 X-Received: by 2002:a17:906:f18f:: with SMTP id gs15mr1333156ejb.474.1604045368493; Fri, 30 Oct 2020 01:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604045368; cv=none; d=google.com; s=arc-20160816; b=RyE7rxafG7dIQ4bSVv1wE0IeJ5MP96qU31k+Qcnzj2V0AzKeyEJmVamEqFNHLZbZKQ 2pc3YzINoeM/VtVK5+ytTXVbTnpnqGZtC9t59jRpN3ur0CS5JjuDeePpYcMin2tW0kNl A5UlfGpnNt/OHiv+5eU8dArEtxDwpqrJmHAgdgNOtSfRVNpLzYylMHvpADeTxKtnqopr 9qTaIaeZeeaT7TnNuLmXYRODiF1D3bRhc5ssgSlSkZ2GuwHTRiYudGuheJaX6/p6GLiB ULtS/0PzqGaCxyO4jJTaKqVMBBEA7A97Y0ua14gnE65ez2goN9oLUmURJgLOiyKr3cIc OEng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A7xAM3qC+XDAbD4KbzbzGA8Z/GZkTvfyFeCVWWmaPOc=; b=jShqAEZJaRcc8abnzDC1yprYoWsyAe30giMrPt4QAtLQ4wrYOJC/c0zDrs1lUUVe5x wrUvPGlIjm2RPqv8iXN+RjHLWohbK+toMGiuqGe/JK/tQ9tr2atDF70mtXlDdHFl4Xlw iUGOJ0zCzl4XVoqD5BTdVEKMQPmF56VkMj1RBoOGrZl0poxzN8Q4PjnkFF0nSnng2rw1 Yrxk7PhtEWA2f/pa+uPEeHTYG1KOBpfsFh41TiUud1b4P5rWlaq9A4+UD8VxZaehOoyK yODp+cJkPUU3qwBwS0bnJSPQGZLyOLR9qo7ordAqNt0f/T3NiS5iPGXPazKYm6PtsR9k 0zfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tVJmbi1Q; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt21si3689826ejb.368.2020.10.30.01.08.52; Fri, 30 Oct 2020 01:09:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tVJmbi1Q; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725944AbgJ3IIW (ORCPT + 99 others); Fri, 30 Oct 2020 04:08:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:38084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ3IIW (ORCPT ); Fri, 30 Oct 2020 04:08:22 -0400 Received: from kernel.org (83-245-197-237.elisa-laajakaista.fi [83.245.197.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E7CF22228; Fri, 30 Oct 2020 08:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604045301; bh=acxrTQkHAJd6J4NM+xeR/HLxVVlvpm5kFDDF2TgWGBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tVJmbi1QFNYykyvuUOJpOGNO0icuPGIQpKRAE+G/AldhJTYHKNiIMlUaO7oet5qOl qeLV4wSNAV+13ID3Ak5mMGiaXivvt8xn8UtvCiXabOQzc6LZDVpeSn1HTDyOIwtqxW ydGux+as4ScLi0mix+qUKMhtS/4xgwUCSoxc3Uc8= Date: Fri, 30 Oct 2020 10:08:15 +0200 From: Jarkko Sakkinen To: Krzysztof Kozlowski Cc: David Howells , Herbert Xu , "David S. Miller" , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc Message-ID: <20201030080815.GA51616@kernel.org> References: <20201029154830.26997-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029154830.26997-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Oct 29, 2020 at 04:48:30PM +0100, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same' > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Randy Dunlap > --- Reviewed-by: Jarkko Sakkinen > crypto/asymmetric_keys/asymmetric_type.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c > index 33e77d846caa..ad8af3d70ac0 100644 > --- a/crypto/asymmetric_keys/asymmetric_type.c > +++ b/crypto/asymmetric_keys/asymmetric_type.c > @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id); > > /** > * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same. > - * @kid_1, @kid_2: The key IDs to compare > + * @kid1: The key ID to compare > + * @kid2: The key ID to compare > */ > bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1, > const struct asymmetric_key_id *kid2) > @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same); > /** > * asymmetric_key_id_partial - Return true if two asymmetric keys IDs > * partially match > - * @kid_1, @kid_2: The key IDs to compare > + * @kid1: The key ID to compare > + * @kid2: The key ID to compare > */ > bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1, > const struct asymmetric_key_id *kid2) > -- > 2.25.1 > > /Jarkko