Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1604045940-33684-1-git-send-email-tiantao6@hisilicon.com>
In-Reply-To: <1604045940-33684-1-git-send-email-tiantao6@hisilicon.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 30 Oct 2020 11:38:38 +0100
Message-ID: <CAMj1kXE-v=mDLUjiL=dhMN+wVs-UNTQiBLdhJftNqVQ3sxSQsQ@mail.gmail.com>
Subject: Re: [PATCH] crypto: arm64 - move const after static
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 30 Oct 2020 at 09:18, Tian Tao <tiantao6@hisilicon.com> wrote:
>
> Fixed the WARNING: Move const after static - use 'static const u8'
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Nak.

What warning is that? This is perfectly valid C, and the const is
already after the static. And in general, const applies to the type on
the left, unless it comes first, so putting it after the type is less
ambiguous:


> ---
>  arch/arm64/crypto/aes-ce-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/aes-ce-glue.c b/arch/arm64/crypto/aes-ce-glue.c
> index 56a5f6f..8ba6f04 100644
> --- a/arch/arm64/crypto/aes-ce-glue.c
> +++ b/arch/arm64/crypto/aes-ce-glue.c
> @@ -77,7 +77,7 @@ int ce_aes_expandkey(struct crypto_aes_ctx *ctx, const u8 *in_key,
>         /*
>          * The AES key schedule round constants
>          */
> -       static u8 const rcon[] = {
> +       static const u8 rcon[] = {
>                 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80, 0x1b, 0x36,
>         };
>
> --
> 2.7.4
>