Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1907338pxx; Sat, 31 Oct 2020 02:09:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCgFdFzquS8SHNSZV9EnJbuKzr0MkEimVMotWUOozwpIgx/b0ir422Deu39Z8pMTGIzmpB X-Received: by 2002:a17:906:3958:: with SMTP id g24mr5248400eje.360.1604135385282; Sat, 31 Oct 2020 02:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604135385; cv=none; d=google.com; s=arc-20160816; b=ioSG50cmhnlYBlOCmBbTcoiBGGOHroQIpszjv/xXg6LxVtpAKuSXbelYCri+P6n8/e 3v37D0vGp8yVLntqD9cIzus2QZNczqSHamE1OZ6wcu43Q7oXxzA8v6zC+cIAYz5ZJMgV W+M12HVQm2x1uw7rWbcYRHLA4Q6y3gwpnZYzorgRX6v6+mVpmpKgHLTWKI7ahulERzMz wG1J6RMDkr5kzJ41spoEOTHOlHVy8PwPxJTwZ6csOZ2B2ELVIsAVeTIphyIkgyZ4mO9z eyhGiMid91IzQTbPOjeTYkdLmX1w/XZJLDjY1eX6UIo7qo3n12O4LCMtWS/9d8rx4t/8 m8gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=0fce+fPXz3qydbWwGj5JU1gc2Z7lSv5IiZ5opTReawQ=; b=0hgJyiHfPD4pFQ2bYWeJDaTThn5M/cg+79V3S66Mb7ToW8UN330gUontHks3gT0T3j 3r3Dr88duAog/TOjnz8dEGaqDDXeHjnHsmkaQSqH5WnqHefLCYRxccGLTR3adu9C+2rM Je7e8dpR6yOaa+P+7MkT3px9NINz1puxDEX4JTAAnK5yj2hWIgoecpDK8JF+QRgSRpXJ N3KFXp8d1Fgb/lglgq+NtgxxWbQ524QY4fX82U7pu2W0LsuiSWZt3MgRL/nE1StupyV4 P4GqxCtIvJ98MmddkkiQxpe6bDWN2BQ9caiUM7RG80Y1bE8scIz7STqnRS4FqnKOhK7t iajw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si1629848ejl.539.2020.10.31.02.09.22; Sat, 31 Oct 2020 02:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbgJaJJA (ORCPT + 99 others); Sat, 31 Oct 2020 05:09:00 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:7389 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbgJaJI6 (ORCPT ); Sat, 31 Oct 2020 05:08:58 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CNYJH0YPyz70vS; Sat, 31 Oct 2020 17:08:47 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Sat, 31 Oct 2020 17:08:35 +0800 From: Weili Qian To: , CC: , , , Subject: [PATCH 5/8] crypto: hisilicon/qm - replace 'sprintf' with 'scnprintf' Date: Sat, 31 Oct 2020 17:07:05 +0800 Message-ID: <1604135228-18410-6-git-send-email-qianweili@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1604135228-18410-1-git-send-email-qianweili@huawei.com> References: <1604135228-18410-1-git-send-email-qianweili@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Replace 'sprintf' with 'scnprintf' to avoid overrun. Signed-off-by: Weili Qian Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/qm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 17f84db..25c5414 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -932,7 +932,8 @@ static ssize_t qm_debug_read(struct file *filp, char __user *buf, return -EINVAL; } mutex_unlock(&file->lock); - ret = sprintf(tbuf, "%u\n", val); + + ret = scnprintf(tbuf, QM_DBG_TMP_BUF_LEN, "%u\n", val); return simple_read_from_buffer(buf, count, pos, tbuf, ret); } -- 2.8.1