Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201028145015.19212-1-schalla@marvell.com> <20201028145015.19212-12-schalla@marvell.com>
In-Reply-To: <20201028145015.19212-12-schalla@marvell.com>
From:   Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date:   Sat, 31 Oct 2020 15:19:09 -0400
Message-ID: <CA+FuTSdVszdtPvpasE2FpZ97WRP1uV5UJMC5KjrnziTUY8UQOw@mail.gmail.com>
Subject: Re: [PATCH v8,net-next,11/12] crypto: octeontx2: add support to
 process the crypto request
To:     Srujana Challa <schalla@marvell.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        Network Development <netdev@vger.kernel.org>,
        linux-crypto@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
        schandran@marvell.com, pathreya@marvell.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 28, 2020 at 5:52 PM Srujana Challa <schalla@marvell.com> wrote:
>
> Attach LFs to CPT VF to process the crypto requests and register
> LF interrupts.
>
> Signed-off-by: Suheil Chandran <schandran@marvell.com>
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
>  drivers/crypto/marvell/octeontx2/Makefile     |   2 +-
>  .../marvell/octeontx2/otx2_cpt_common.h       |   3 +
>  .../marvell/octeontx2/otx2_cpt_reqmgr.h       | 145 +++++
>  drivers/crypto/marvell/octeontx2/otx2_cptlf.h |   7 +
>  .../marvell/octeontx2/otx2_cptvf_main.c       | 196 +++++++
>  .../marvell/octeontx2/otx2_cptvf_mbox.c       |  26 +
>  .../marvell/octeontx2/otx2_cptvf_reqmgr.c     | 532 ++++++++++++++++++
>  7 files changed, 910 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/crypto/marvell/octeontx2/otx2_cptvf_reqmgr.c


> +static int init_tasklet_work(struct otx2_cptlfs_info *lfs)
> +{
> +       struct otx2_cptlf_wqe *wqe;
> +       int i, ret = 0;
> +
> +       for (i = 0; i < lfs->lfs_num; i++) {
> +               wqe = kzalloc(sizeof(struct otx2_cptlf_wqe), GFP_KERNEL);
> +               if (!wqe) {
> +                       ret = -ENOMEM;
> +                       goto cleanup_tasklet;
> +               }
> +
> +               tasklet_init(&wqe->work, cptlf_work_handler, (u64) wqe);
> +               wqe->lfs = lfs;
> +               wqe->lf_num = i;
> +               lfs->lf[i].wqe = wqe;
> +       }
> +       return 0;
> +cleanup_tasklet:

nit: here and elsewhere, please leave an empty line between the return
statement and subsequent label.