Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1060728pxb; Thu, 5 Nov 2020 23:03:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfEYV2MtamYIm/fP3n17YtO7u/yvfYlhEqbxQBASz++gpiJkyNHTVp8yBeZoN+wVD7lp6q X-Received: by 2002:a17:906:6a57:: with SMTP id n23mr705387ejs.315.1604646208602; Thu, 05 Nov 2020 23:03:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604646208; cv=none; d=google.com; s=arc-20160816; b=TCX+Jy9mTInNuwnjQROPCLXMR0Eo8v5oxFsEySRTIVC8YfKrITMe/ky81wX08o2rTF nQ5w+OzjU4R00SqLkBGNdBmB2OOGjCH0Hyu306O395qN06aa0AlnmABmLnZQz8yJjMAQ EIZDY+Gv0X+Oh7K6kR0LjCbObwOLO3ROGA13cAg6g8R0kT9hsfX0/XzhkfpFyj6f+R9k zrq6H6TJu0XEvw5aIXOaqJlSQ3F52YRYM+5nC2OlIK9zSOKxmqhaBPk0yIZqgjhC/KgU obHSsNfsEJta/fuyfwg7MzNDqTuSdLxbR3aml21sAkNdD+9GD1n4oa7TP6LWcqRIZg9X GdOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ip4ALc/dndLA4CfYvXX6Is0Www6/TbYZreOVnUBdUAg=; b=pXFjXU5RXdDtVuvmzqbr1uqiJPHegt0fgNTdHOCsXl0m4mT2uWQBPVA2sgL29r1ScO d4xdTY6bcpxFblUpZWjWtr/mEpvQREvMyHLiq1De626WZfJwyYhJ9INmBk9No4jW/2j0 OnX6RLDblc2sMrXFsS0Vdw2ZS3mZbVP0oM1LJYpBHtYQcrZ/vmd5XgGOd6waT7q+IrMk 0Bz0WVzVv0qrUUhNxrRZybfs32ZrpEw+F0DVmiPspYHO74zHR6zyzrP+RLtnMyFmx1EF t3RxKcoLlvLEqWrD+iysBA3LFSkFZ2mutv4bhxjXy++qcfWnzuMIHzW/pJy51wMU7Kb7 QQDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si223932eje.363.2020.11.05.23.03.05; Thu, 05 Nov 2020 23:03:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgKFHCv (ORCPT + 99 others); Fri, 6 Nov 2020 02:02:51 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:35074 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgKFHCv (ORCPT ); Fri, 6 Nov 2020 02:02:51 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kavlW-000836-10; Fri, 06 Nov 2020 18:02:31 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 06 Nov 2020 18:02:30 +1100 Date: Fri, 6 Nov 2020 18:02:30 +1100 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: "David S. Miller" , Russell King , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback Message-ID: <20201106070229.GG11620@gondor.apana.org.au> References: <20201028090320.4222-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201028090320.4222-1-horia.geanta@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Oct 28, 2020 at 11:03:20AM +0200, Horia Geantă wrote: > Loading the module deadlocks since: > -local cbc(aes) implementation needs a fallback and > -crypto API tries to find one but the request_module() resolves back to > the same module > > Fix this by changing the module alias for cbc(aes) and > using the NEED_FALLBACK flag when requesting for a fallback algorithm. > > Fixes: 00b99ad2bac2 ("crypto: arm/aes-neonbs - Use generic cbc encryption path") > Signed-off-by: Horia Geantă > --- > arch/arm/crypto/aes-neonbs-glue.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt