Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3100481pxb; Mon, 16 Nov 2020 05:57:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaGICrYxIrZc7JO9Fkcnlmv00njsj9W3RUZok0HAPdlE7lc6D1BfoS/4yJX16r4lN3B1+d X-Received: by 2002:a17:906:f1d8:: with SMTP id gx24mr14326211ejb.73.1605535028905; Mon, 16 Nov 2020 05:57:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605535028; cv=none; d=google.com; s=arc-20160816; b=eXQ3sOLXgcDL9B9gy0cr0pUfU5sPrKtK/kqtEe1PHoIiqtWXfnZMMzABK3WlLfjJXI gDQ0UPSAanqoqfBd2EFMfvLe/zWeNXI52y6Yyq1y4/uyQJxOxZ5p/6ZaEBtaRd2M8lcg Ey5Wtdn9LZJqwtiq5Z7k/7cGjbL3zaL0xi4a4cTUCYQKhfcUQPJwVrI4PMzbdHSHW5DC z86ndu5Dy8ZOTwb6s7UmVKfzDUBHC0v72NeXr5gHO/KsAC2GQ5ovwg9LA6v987ygvmWI luYTC2uRRjdR97o/hSzOq0ZpGZrhOCiIQafvwqZEZgjtXS2XZfekEe9BCWdm1n+OA93l 16Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=LA6HiyjtrQWg93rXzUxCKFCbWr20SEsMu/GK7GDnTM4=; b=qnIjS/wi6ktX+xGJ3cD8vLgk9dXjwJgmu0OopniFBKs+p5wc3NWyeItbGA2WS4HCic gn8/eOGUyEkmiaPPpkG8YEmbTb1rvkLZDm0f39nj8ppkVFyrymsfzGiFHn6KTdGdpnG5 y0CnWxDJ2q5TbWhgRZCjQWmKnoy+TJSmIOdfH1wLDw838E09j9iI9604VtYcdNPS/Dc+ /Ck+DqxaPCrON3SYp8w2VztMpLxynIZvVxZPzvps7fLXf4DdvAXgvmcXMzahypG4HoSH y0FvXwoZqwBhlxqgDhNia5ED9nSjFQv4IZK8V14LNKye1CXM5xnqxNwb9lJJGA1ndlmX 3BSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iblwlVcd; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id am4si11887431ejc.256.2020.11.16.05.56.45; Mon, 16 Nov 2020 05:57:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iblwlVcd; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729849AbgKPNyv (ORCPT + 99 others); Mon, 16 Nov 2020 08:54:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729825AbgKPNyt (ORCPT ); Mon, 16 Nov 2020 08:54:49 -0500 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1D2CC0613D1 for ; Mon, 16 Nov 2020 05:54:47 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id v12so14160075pfm.13 for ; Mon, 16 Nov 2020 05:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LA6HiyjtrQWg93rXzUxCKFCbWr20SEsMu/GK7GDnTM4=; b=iblwlVcd2lUD/gwKL5jWgNtBU8xtXkfkke8Of+1dHqmGyy37nax0rkrq4lAXptvJVb AXqrTry0jNdofQ+ymr26F5xvtaGj2ALrfbMCnUWvEynp27GBSifY99vEi2dweI6enESU vy36OwiE+cI6m+WwQAamyl1AOUTuLz4liMHynQe16YSSqU+JdC4W2cKigHXBhsY+lJfD df9hu4J1U6K00TDaQluTa930RJUmRhNzpxugl2rmno4CG3ZBTDMbYQWTfAJdDl9Vm86E zQDaMD03Wj8qHlYlgW3jmyS7s2L/bHD9blRaKnd4GVwAh71hLJPRRdAdhXjqbvQRg633 0j2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LA6HiyjtrQWg93rXzUxCKFCbWr20SEsMu/GK7GDnTM4=; b=tWlx6+1E7/IypBCOUn0ZEa5tqMJG/hucMP84Kn7rOfoPra1W4QeHUDUYR/g8Pd7Nrr IJCbtns2TlOi2c7ZNeslhTFo5GP1mbE0o0xE4cCju4IX3hqH9SUF51OTQA3CcSYO2goI /MD1sqz9NProMW1Dq0Vc7dMEW7OQaldi3D35EL16C/8vwDHj1hh/0Y0UrXZJLk831q0q 6ELlqaoY12cX0v+1+87lG/iG5j2bys68jYMOSdDA0UfjPsYoegPct0LCFAbfroNfAki5 MRmpRaPa5sJ02hVxtwyA/vIJ+BBmJxnCO5uZzU5BXn4p7MjnmvKi9g3HdGmCRkmtM10m naJg== X-Gm-Message-State: AOAM531WLCwUlCK+dxrBnJddHsDZ7rCiFM77OgGwdC9MKU04Ka7N+cO6 nArhuIIqpweC7Z9INX2+lFAuLA== X-Received: by 2002:a17:90b:4c0b:: with SMTP id na11mr3329213pjb.0.1605534887618; Mon, 16 Nov 2020 05:54:47 -0800 (PST) Received: from localhost.localdomain ([163.172.76.58]) by smtp.googlemail.com with ESMTPSA id u22sm15864031pgf.24.2020.11.16.05.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 05:54:47 -0800 (PST) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , stable@vger.kernel.org Subject: [PATCH v3 5/7] crypto: sun4i-ss: initialize need_fallback Date: Mon, 16 Nov 2020 13:53:43 +0000 Message-Id: <20201116135345.11834-6-clabbe@baylibre.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201116135345.11834-1-clabbe@baylibre.com> References: <20201116135345.11834-1-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The need_fallback is never initialized and seem to be always true at runtime. So all hardware operations are always bypassed. Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index 8f4621826330..7f4c97cc9627 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -179,7 +179,7 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) unsigned int obo = 0; /* offset in bufo*/ unsigned int obl = 0; /* length of data in bufo */ unsigned long flags; - bool need_fallback; + bool need_fallback = false; if (!areq->cryptlen) return 0; -- 2.26.2